Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2058673002:
Rewrite LayoutTests/shadow-dom/event-composed-path.html (Closed)
DescriptionRewrite LayoutTests/shadow-dom/event-composed-path.html
Make the test more comprehensive and redable.
BUG=531990
Committed: https://crrev.com/0e35e056ed2bde8888f123e01c55c747aad0fdfc
Cr-Commit-Position: refs/heads/master@{#400101}
Patch Set 1 #Patch Set 2 : rebased #
Total comments: 20
Patch Set 3 : fix #
Dependent Patchsets: Messages
Total messages: 25 (10 generated)
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058673002/1
hayato@chromium.org changed reviewers: + kochi@chromium.org, tkent@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
It looks the patch can not be applied. Let me upload another patch set.
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
rebased
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058673002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html (right): https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:17: }, 'Event Path test1'); 'Event Path testN' isn't a good description. Please write more descriptive one. e.g. Even Path without ShadowRoots. https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:48: let path = ['target','sr', 'host', 'test3']; nit: add a space after the first comma. https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:93: let path = ['target','sr2', 'host2', 'sr1', 'host1', 'test5']; nit: add a space after the first comma. https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:120: let path = ['target','sr2', 'host2', 'sr1', 'host1', 'test6']; nit: add a space after the first comma. https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:147: let path = ['target','sr2', 'host2', 'sr1', 'host1', 'test7']; nit: add a space after the first comma. https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:172: let path = ['target','slot', 'sr1', 'host1', 'test8']; nit: add a space after the first comma. https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:190: let path = ['target','slot', 'sr1', 'host1', 'test9']; nit: add a space after the first comma. https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:218: let path = ['target','slot1', 'slot2', 'sr2', 'host2', 'sr1', 'host1', 'test10']; nit: add a space after the first comma. https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:241: let path = ['target','slot1', 'slot2', 'sr2', 'host2', 'sr1', 'host1', 'test11']; nit: add a space after the first comma https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:242: let path1 = ['target','slot1', 'host2', 'sr1', 'host1', 'test11']; Ditto.
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
fix
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058673002/40001
The CQ bit was unchecked by hayato@chromium.org
The CQ bit was checked by hayato@chromium.org
Thank you for the review. https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html (right): https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:17: }, 'Event Path test1'); Done. Added descriptive names to every tests. https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:48: let path = ['target','sr', 'host', 'test3']; Done https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:93: let path = ['target','sr2', 'host2', 'sr1', 'host1', 'test5']; Done https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:120: let path = ['target','sr2', 'host2', 'sr1', 'host1', 'test6']; Done https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:147: let path = ['target','sr2', 'host2', 'sr1', 'host1', 'test7']; Done https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:172: let path = ['target','slot', 'sr1', 'host1', 'test8']; Done https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:190: let path = ['target','slot', 'sr1', 'host1', 'test9']; Done https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:218: let path = ['target','slot1', 'slot2', 'sr2', 'host2', 'sr1', 'host1', 'test10']; Done https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:241: let path = ['target','slot1', 'slot2', 'sr2', 'host2', 'sr1', 'host1', 'test11']; Done https://codereview.chromium.org/2058673002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html:242: let path1 = ['target','slot1', 'host2', 'sr1', 'host1', 'test11']; Done
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org Link to the patchset: https://codereview.chromium.org/2058673002/#ps40001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058673002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Rewrite LayoutTests/shadow-dom/event-composed-path.html Make the test more comprehensive and redable. BUG=531990 ========== to ========== Rewrite LayoutTests/shadow-dom/event-composed-path.html Make the test more comprehensive and redable. BUG=531990 Committed: https://crrev.com/0e35e056ed2bde8888f123e01c55c747aad0fdfc Cr-Commit-Position: refs/heads/master@{#400101} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/0e35e056ed2bde8888f123e01c55c747aad0fdfc Cr-Commit-Position: refs/heads/master@{#400101} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
