[Draft] Fix canceling pin prompt causes host overload

remoting/protocol/jingle_session.h

Index: remoting/protocol/jingle_session.h
diff --git a/remoting/protocol/jingle_session.h b/remoting/protocol/jingle_session.h
index 189cb53c45fb2cabb4af82159c7cba4507942390..23dff1c56d7b4e9867a635dd37ad433fbb7daf4b 100644
--- a/remoting/protocol/jingle_session.h
+++ b/remoting/protocol/jingle_session.h
@@ -131,10 +131,15 @@ class JingleSession : public Session,
   bool InitializeConfigFromDescription(const ContentDescription* description);
 
   // Called after the initial incoming authenticator message is processed.
+

[Sergey Ulanov, 2014/03/27 19:06:55]

Don't need this empty line.

[kelvinp, 2014/04/01 21:23:49]

Done.

   void ContinueAcceptIncomingConnection();
+
   // Called after subsequent authenticator messages are processed.
   void ProcessAuthenticationStep();
 
+  // Called after the authenticating step is finished

[Sergey Ulanov, 2014/03/27 19:06:55]

nit: add '.' at the end.

[kelvinp, 2014/04/01 21:23:49]

Done.

+  void ContinueAuthenticationStep();
+
   // Terminates the session and sends session-terminate if it is
   // necessary. |error| specifies the error code in case when the
   // session is being closed due to an error.
@@ -143,10 +148,14 @@ class JingleSession : public Session,
   // Sets |state_| to |new_state| and calls state change callback.
   void SetState(State new_state);
 
+  // Returns true if the state of the session is not CLOSED or FAILED
+  bool is_session_active();
+
   JingleSessionManager* session_manager_;
   std::string peer_jid_;
   scoped_ptr<CandidateSessionConfig> candidate_config_;
   Session::EventHandler* event_handler_;
+  base::WeakPtrFactory<JingleSession> weak_factory_;

[Sergey Ulanov, 2014/03/27 19:06:55]

We normally put weak_factory_ as last field - that's to ensure that all weak
pointers are invalidated before all other fields are destroyed.

[kelvinp, 2014/04/01 21:23:49]

Done.

 
   std::string session_id_;
   State state_;