remoting/host/chromoting_host_unittest.cc - Issue 205583011: [Draft] Fix canceling pin prompt causes host overload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/chromoting_host_unittest.cc

Issue 205583011: [Draft] Fix canceling pin prompt causes host overload (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix Unittests and also reject connections upon authenticating Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/chromoting_host_unittest.cc

diff --git a/remoting/host/chromoting_host_unittest.cc b/remoting/host/chromoting_host_unittest.cc

index 1410371a9bc8b5049461e0246697020ac5377808..1f42f3a7765129b0effa9846859fef0012f4cc97 100644

--- a/remoting/host/chromoting_host_unittest.cc

+++ b/remoting/host/chromoting_host_unittest.cc

@@ -607,9 +607,10 @@ TEST_F(ChromotingHostTest, IncomingSessionOverload) {

protocol::SessionManager::IncomingSessionResponse response =

protocol::SessionManager::DECLINE;

- host_->OnIncomingSession(session_unowned1_.release(), &response);

- EXPECT_EQ(protocol::SessionManager::ACCEPT, response);

+ host_->OnIncomingSession(session_unowned1_.release(), &response);

+ EXPECT_EQ(protocol::SessionManager::ACCEPT, response);

+ host_->OnSessionAuthenticating(NULL);

Sergey Ulanov 2014/03/27 19:06:55 s/NULL/host_->clients_.front()/

kelvinp 2014/04/01 21:23:49 Done.

host_->OnIncomingSession(session_unowned2_.get(), &response);

EXPECT_EQ(protocol::SessionManager::OVERLOAD, response);