[Draft] Fix canceling pin prompt causes host overload

remoting/protocol/jingle_session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_JINGLE_SESSION_H_
 #define REMOTING_PROTOCOL_JINGLE_SESSION_H_
 
 #include <list>
 #include <map>
 #include <set>
@@ skipping 113 matching lines @@
   void OnSessionInfo(const JingleMessage& message,
                      const ReplyCallback& reply_callback);
   void OnTerminate(const JingleMessage& message,
                    const ReplyCallback& reply_callback);
   void ProcessTransportInfo(const JingleMessage& message);
 
   // Called from OnAccept() to initialize session config.
   bool InitializeConfigFromDescription(const ContentDescription* description);
 
   // Called after the initial incoming authenticator message is processed.
+

[Sergey Ulanov, 2014/03/27 19:06:55]

Don't need this empty line.

[kelvinp, 2014/04/01 21:23:49]

Done.

   void ContinueAcceptIncomingConnection();
+
   // Called after subsequent authenticator messages are processed.
   void ProcessAuthenticationStep();
 
+  // Called after the authenticating step is finished

[Sergey Ulanov, 2014/03/27 19:06:55]

nit: add '.' at the end.

[kelvinp, 2014/04/01 21:23:49]

Done.

+  void ContinueAuthenticationStep();
+
   // Terminates the session and sends session-terminate if it is
   // necessary. |error| specifies the error code in case when the
   // session is being closed due to an error.
   void CloseInternal(ErrorCode error);
 
   // Sets |state_| to |new_state| and calls state change callback.
   void SetState(State new_state);
 
+  // Returns true if the state of the session is not CLOSED or FAILED
+  bool is_session_active();
+
   JingleSessionManager* session_manager_;
   std::string peer_jid_;
   scoped_ptr<CandidateSessionConfig> candidate_config_;
   Session::EventHandler* event_handler_;
+  base::WeakPtrFactory<JingleSession> weak_factory_;

[Sergey Ulanov, 2014/03/27 19:06:55]

We normally put weak_factory_ as last field - that's to ensure that all weak
pointers are invalidated before all other fields are destroyed.

[kelvinp, 2014/04/01 21:23:49]

Done.

 
   std::string session_id_;
   State state_;
   ErrorCode error_;
 
   SessionConfig config_;
   bool config_is_set_;
 
   scoped_ptr<Authenticator> authenticator_;
 
@@ skipping 12 matching lines @@
   // Pending remote candidates, received before the local channels were created.
   std::list<JingleMessage::NamedCandidate> pending_remote_candidates_;
 
   DISALLOW_COPY_AND_ASSIGN(JingleSession);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_JINGLE_SESSION_H_