Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2055713003: gpu: Implement GL_INTEL_framebuffer_CMAA via shaders in the GPU Service (Closed)

Created:
4 years, 6 months ago by adrian.belgun
Modified:
4 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Implement GL_INTEL_framebuffer_CMAA via shaders in the GPU Service Based on OpenGLES code developed by Filip Strugar and Jon Kennedy. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" Co-Authored-By: Filip Strugar <filip.strugar@intel.com>; Co-Authored-By: Jon Kennedy <jon.kennedy@intel.com>; CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/8a992f1e4ceca6d3d933614953cfc4d80bf3dffe Cr-Commit-Position: refs/heads/master@{#400438}

Patch Set 1 #

Total comments: 36

Patch Set 2 : Respond to review #

Total comments: 2

Patch Set 3 : Use DCHECK. #

Patch Set 4 : Fix component & windows build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1990 lines, -1 line) Patch
M gpu/command_buffer/service/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 2 chunks +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 3 chunks +15 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.h View 1 2 3 1 chunk +102 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc View 1 2 3 1 chunk +1826 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 5 chunks +31 lines, -1 line 0 comments Download
M gpu/command_buffer_service.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_switches.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
adrian.belgun
This patch adds a browser implementation of the CMAA post processing algorithm via GL shaders. ...
4 years, 6 months ago (2016-06-09 11:23:47 UTC) #4
Ken Russell (switch to Gerrit)
The addition of the switch in ui/gl lgtm. zmo or piman should review the changes ...
4 years, 6 months ago (2016-06-13 19:38:01 UTC) #6
piman
https://codereview.chromium.org/2055713003/diff/1/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc File gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc (right): https://codereview.chromium.org/2055713003/diff/1/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc#newcode227 gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc:227: glGetIntegerv(GL_MAX_DRAW_BUFFERS, &max_draw_buffers); Here and below: we already have this ...
4 years, 6 months ago (2016-06-13 22:24:44 UTC) #7
adrian.belgun
Uploaded new patch set with changes as per review. https://codereview.chromium.org/2055713003/diff/1/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc File gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc (right): https://codereview.chromium.org/2055713003/diff/1/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc#newcode227 gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc:227: ...
4 years, 6 months ago (2016-06-16 14:53:15 UTC) #8
piman
LGTM+nit https://codereview.chromium.org/2055713003/diff/20001/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc File gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc (right): https://codereview.chromium.org/2055713003/diff/20001/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc#newcode210 gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc:210: if (!initialized_ || !decoder || !framebuffer) nit: decoder ...
4 years, 6 months ago (2016-06-16 17:49:27 UTC) #9
adrian.belgun
Thank you for reviewing this! https://codereview.chromium.org/2055713003/diff/20001/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc File gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc (right): https://codereview.chromium.org/2055713003/diff/20001/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc#newcode210 gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc:210: if (!initialized_ || !decoder ...
4 years, 6 months ago (2016-06-17 11:51:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055713003/40001
4 years, 6 months ago (2016-06-17 11:52:09 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/111671)
4 years, 6 months ago (2016-06-17 12:08:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055713003/60001
4 years, 6 months ago (2016-06-17 14:52:23 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-17 16:29:19 UTC) #22
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 16:30:35 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8a992f1e4ceca6d3d933614953cfc4d80bf3dffe
Cr-Commit-Position: refs/heads/master@{#400438}

Powered by Google App Engine
This is Rietveld 408576698