Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2055713002: Add UseCounter for Date.parse's legacy parse heuristics. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounter for Date.parse's legacy parse heuristics. R=adamk@chromium.org, asvitkine@chromium.org BUG=chromium:618595 Committed: https://crrev.com/1a73d11e65f5af4fc946a00ed1a2b7022ed28c64 Cr-Commit-Position: refs/heads/master@{#399420}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (6 generated)
Yang
4 years, 6 months ago (2016-06-09 08:01:31 UTC) #1
Yang
+Jochen
4 years, 6 months ago (2016-06-09 08:05:31 UTC) #3
Yang
On 2016/06/09 08:05:31, Yang wrote: > +Jochen This CL depends on this V8 patch: https://codereview.chromium.org/2050733004
4 years, 6 months ago (2016-06-09 08:08:31 UTC) #4
adamk
lgtm, but I think you'll need jochen too as I'm not (currently) a blink core ...
4 years, 6 months ago (2016-06-09 08:11:43 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-09 16:08:35 UTC) #6
Alexei Svitkine (slow)
lgtm
4 years, 6 months ago (2016-06-09 21:47:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055713002/20001
4 years, 6 months ago (2016-06-13 05:29:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/19957) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-13 05:31:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055713002/40001
4 years, 6 months ago (2016-06-13 07:47:24 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-13 09:21:43 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 09:21:45 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 09:23:00 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1a73d11e65f5af4fc946a00ed1a2b7022ed28c64
Cr-Commit-Position: refs/heads/master@{#399420}

Powered by Google App Engine
This is Rietveld 408576698