Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1751803002: LayoutTests: prepare inspector/debugger-step tests for V8 debugger change. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 4 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutTests: prepare inspector/debugger-step tests for V8 debugger change. - End of a script will no longer has a break location for the implicitly added return value. - Variable declarations without initialization will no longer break (because this cannot be implemented in the interpreter). R=jochen@chromium.org BUG=chromium:590992 Committed: https://crrev.com/274f768193139433768d21986980aa8050e7541d Cr-Commit-Position: refs/heads/master@{#378425}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -38 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-async1-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-document-write.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-document-write-expected.txt View 1 chunk +3 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-inlined-scripts.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-inlined-scripts-expected.txt View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-over-document-write.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-over-document-write-expected.txt View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-over-inlined-scripts.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-over-inlined-scripts-expected.txt View 2 chunks +0 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
Yang
4 years, 9 months ago (2016-03-01 08:04:05 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1751803002/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1751803002/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode317 third_party/WebKit/LayoutTests/TestExpectations:317: # crbug.com/498539 [ Precise ] inspector/sources/debugger-step/debugger-step-over-inlined-scripts.html [ Pass Timeout ...
4 years, 9 months ago (2016-03-01 08:45:52 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-01 08:49:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751803002/1
4 years, 9 months ago (2016-03-01 08:50:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/189367)
4 years, 9 months ago (2016-03-01 09:50:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751803002/20001
4 years, 9 months ago (2016-03-01 10:51:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-01 12:03:11 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 12:05:21 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/274f768193139433768d21986980aa8050e7541d
Cr-Commit-Position: refs/heads/master@{#378425}

Powered by Google App Engine
This is Rietveld 408576698