Add UseCounter for Date.parse's legacy parse heuristics.

Add UseCounter for Date.parse's legacy parse heuristics.

R=adamk@chromium.org, jochen@chromium.org
BUG=chromium:618595
Committed: https://crrev.com/d77963feeab432464c200fed24851600bdc4b97d
Cr-Commit-Position: refs/heads/master@{#36846}

[adamk, 2016-06-09 08:10:53]

lgtm

[Yang, 2016-06-09 08:39:14]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-06-09 08:39:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050733004/1

[commit-bot: I haz the power, 2016-06-09 09:08:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-09 09:10:06]

Description was changed from

==========
Add UseCounter for Date.parse's legacy parse heuristics.

R=adamk@chromium.org, jochen@chromium.org
BUG=chromium:618595
==========

to

==========
Add UseCounter for Date.parse's legacy parse heuristics.

R=adamk@chromium.org, jochen@chromium.org
BUG=chromium:618595

Committed: https://crrev.com/d77963feeab432464c200fed24851600bdc4b97d
Cr-Commit-Position: refs/heads/master@{#36846}
==========

[commit-bot: I haz the power, 2016-06-09 09:10:07]

Patchset 1 (id:??) landed as
https://crrev.com/d77963feeab432464c200fed24851600bdc4b97d
Cr-Commit-Position: refs/heads/master@{#36846}

[Dan Ehrenberg, 2016-06-09 12:16:30]

littledan@chromium.org changed reviewers:
+ domenic@chromium.org, littledan@chromium.org

[Dan Ehrenberg, 2016-06-09 12:16:30]

littledan@chromium.org changed reviewers:
+ domenic@chromium.org, littledan@chromium.org

[Dan Ehrenberg, 2016-06-09 12:16:31]

https://codereview.chromium.org/2050733004/diff/1/src/dateparser-inl.h
File src/dateparser-inl.h (right):

https://codereview.chromium.org/2050733004/diff/1/src/dateparser-inl.h#newcod...
src/dateparser-inl.h:176: isolate->CountUsage(v8::Isolate::kLegacyDateParser);
I bet we'll find that this gets hit a significant amount of the time (based on
the fact that we and other browsers get a bunch of bug reports about this path).
If we want to lock things down, we will probably need some more fine-grained use
counters. For example, we ignore arbitrary characters at the end of a date, but
I don't believe other browsers do, so this may be something specific to count.

[Dan Ehrenberg, 2016-06-09 12:16:32]

https://codereview.chromium.org/2050733004/diff/1/src/dateparser-inl.h
File src/dateparser-inl.h (right):

https://codereview.chromium.org/2050733004/diff/1/src/dateparser-inl.h#newcod...
src/dateparser-inl.h:176: isolate->CountUsage(v8::Isolate::kLegacyDateParser);
I bet we'll find that this gets hit a significant amount of the time (based on
the fact that we and other browsers get a bunch of bug reports about this path).
If we want to lock things down, we will probably need some more fine-grained use
counters. For example, we ignore arbitrary characters at the end of a date, but
I don't believe other browsers do, so this may be something specific to count.

[Yang, 2016-06-09 12:37:39]

On 2016/06/09 12:16:32, Dan Ehrenberg wrote:
> https://codereview.chromium.org/2050733004/diff/1/src/dateparser-inl.h
> File src/dateparser-inl.h (right):
> 
>
https://codereview.chromium.org/2050733004/diff/1/src/dateparser-inl.h#newcod...
> src/dateparser-inl.h:176: isolate->CountUsage(v8::Isolate::kLegacyDateParser);
> I bet we'll find that this gets hit a significant amount of the time (based on
> the fact that we and other browsers get a bunch of bug reports about this
path).
> If we want to lock things down, we will probably need some more fine-grained
use
> counters. For example, we ignore arbitrary characters at the end of a date,
but
> I don't believe other browsers do, so this may be something specific to count.

Well the way it's currently implemented we only count if the legacy parser
succeeds.