components/autofill/content/common/autofill_messages.h - Issue 2055633003: [Password Generation] Sends form classifier vote to autofill server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 2055633003: [Password Generation] Sends form classifier vote to autofill server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pg_form_classification

Patch Set: replaced " DCHECK(client_->IsSavingAndFillingEnabledForCurrentPage()) Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_generation_agent_browsertest.cc ('k') | components/autofill/content/renderer/password_generation_agent.h » ('j') | components/password_manager/core/browser/password_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index 397cb5ffbaa24e1c233744d8a9a4637fce50a335..09f446aa1d89c6c1bef94ccdd57a9275d00821c3 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -333,6 +333,12 @@ IPC_MESSAGE_ROUTED1(AutofillHostMsg_PresaveGeneratedPassword,

IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordNoLongerGenerated,

autofill::PasswordForm)

+// Sends the outcome of HTML parsing based form classifier that detects the

+// forms where password generation should be available.

+IPC_MESSAGE_ROUTED2(AutofillHostMsg_SaveGenerationFieldDetectedByClassifier,

+ autofill::PasswordForm,

+ base::string16 /* generation field */)

// Instruct the browser to show a popup with suggestions filled from data

// associated with |key|. The popup will use |text_direction| for displaying

// text.