Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6489)

Unified Diff: chrome/renderer/autofill/password_generation_agent_browsertest.cc

Issue 2055633003: [Password Generation] Sends form classifier vote to autofill server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pg_form_classification
Patch Set: replaced " DCHECK(client_->IsSavingAndFillingEnabledForCurrentPage()) Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/password_generation_agent_browsertest.cc
diff --git a/chrome/renderer/autofill/password_generation_agent_browsertest.cc b/chrome/renderer/autofill/password_generation_agent_browsertest.cc
index ddce3ad1e1a5d40cee9f0a8136f33b20cc84e76b..2743a9af67ea17ca6e4986c687f9e66ec536edf7 100644
--- a/chrome/renderer/autofill/password_generation_agent_browsertest.cc
+++ b/chrome/renderer/autofill/password_generation_agent_browsertest.cc
@@ -72,6 +72,19 @@ class PasswordGenerationAgentTest : public ChromeRenderViewTest {
render_thread_->sink().ClearMessages();
}
+ void ExpectFormClassifierVoteReceived(
+ const base::string16& expected_generation_element) {
+ const IPC::Message* message =
+ render_thread_->sink().GetFirstMessageMatching(
+ AutofillHostMsg_SaveGenerationFieldDetectedByClassifier::ID);
+ ASSERT_TRUE(message);
+ std::tuple<autofill::PasswordForm, base::string16> actual_parameters;
+ AutofillHostMsg_SaveGenerationFieldDetectedByClassifier::Read(
+ message, &actual_parameters);
+ EXPECT_EQ(expected_generation_element, std::get<1>(actual_parameters));
+ render_thread_->sink().ClearMessages();
+ }
+
void ShowGenerationPopUpManually(const char* element_id) {
FocusField(element_id);
AutofillMsg_UserTriggeredGeneratePassword msg(0);
@@ -647,4 +660,14 @@ TEST_F(PasswordGenerationAgentTest, PresavingGeneratedPassword) {
}
}
+TEST_F(PasswordGenerationAgentTest, FormClassifierVotesSignupForm) {
+ LoadHTMLWithUserGesture(kAccountCreationFormHTML);
+ ExpectFormClassifierVoteReceived(base::ASCIIToUTF16("first_password"));
+}
+
+TEST_F(PasswordGenerationAgentTest, FormClassifierVotesSigninForm) {
+ LoadHTMLWithUserGesture(kSigninFormHTML);
+ ExpectFormClassifierVoteReceived(base::string16());
+}
+
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698