[Password Generation] Sends form classifier vote to autofill server

components/password_manager/core/browser/password_manager.cc

Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 766212c8e2b760ae98fe579456e90834bc4fb216..990424c8882682d771d002bd5bb330af3d1d9d19 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -231,6 +231,16 @@ void PasswordManager::SetGenerationElementAndReasonForForm(
   manager->FetchDataFromPasswordStore();
 }
 
+void PasswordManager::SaveGenerationFieldDetectedByClassifier(
+    const autofill::PasswordForm& form,
+    const base::string16& generation_field) {
+  if (!client_->IsSavingAndFillingEnabledForCurrentPage())

[vabr (Chromium), 2016/06/20 08:32:29]

I would like to understand more what happens here. You say this is reproduced in
tests -- does that also correspond to a behaviour which a user can observe?

How does it happen that this method is called when saving & filling is disabled?
Is it some kind of delay during which a navigation happens?

How do we know that it is safe to just give up on line 238?

(It would be good to summarise the answers in a comment above line 237.)

[kolos1, 2016/06/20 09:09:15]

PasswordGenerationAgent::FindPossibleGenerationForm() might be called even if
saving&filling are disabled. Is it by design?  

In PasswordGenerationAgent::DetermineGenerationElement(), we didn't go further
if we didn't received positive vote from autofill server (i.e.
OnFormsEligibleForGenerationFound should be called, but the sender,
PasswordGenerationManager::DetectFormsEligibleForGeneration, checks if the
saving&filling are enabled).

+    return;
+  PasswordFormManager* form_manager = GetMatchingPendingManager(form);
+  if (form_manager)
+    form_manager->SaveGenerationFieldDetectedByClassifier(generation_field);
+}
+
 void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {
   bool is_saving_and_filling_enabled =
       client_->IsSavingAndFillingEnabledForCurrentPage();