components/autofill/content/renderer/password_generation_agent.h - Issue 2055633003: [Password Generation] Sends form classifier vote to autofill server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_generation_agent.h

Issue 2055633003: [Password Generation] Sends form classifier vote to autofill server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pg_form_classification

Patch Set: Changed enum values Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/common/autofill_messages.h ('K') | « components/autofill/content/common/autofill_messages.h ('k') | components/autofill/content/renderer/password_generation_agent.cc » ('j') | components/password_manager/core/browser/password_form_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_generation_agent.h

diff --git a/components/autofill/content/renderer/password_generation_agent.h b/components/autofill/content/renderer/password_generation_agent.h

index d5ae1ee505a5513a88c2e3456dfd88bdd0cc1519..b36b74c680ad2cd1221fad23993dfae023d3fe5a 100644

--- a/components/autofill/content/renderer/password_generation_agent.h

+++ b/components/autofill/content/renderer/password_generation_agent.h

@@ -107,6 +107,10 @@ class PasswordGenerationAgent : public content::RenderFrameObserver {

// generation popup at this field.

void OnUserTriggeredGeneratePassword();

+ // Runs HTML parsing based classifier and saves its outcome to proto.

+ void RunFormClassifierAndSaveVote(blink::WebFormElement& web_form,

dvadym 2016/06/16 10:04:38 Can we use const blink::WebFormElement&?

kolos1 2016/06/16 13:28:44 Done.

+ const PasswordForm& form);

// Creates a password form to presave a generated password. It copies behavior

// of CreatePasswordFormFromWebForm/FromUnownedInputElements, but takes