Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: components/autofill/content/renderer/password_generation_agent.cc

Issue 2055633003: [Password Generation] Sends form classifier vote to autofill server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pg_form_classification
Patch Set: Changed enum values Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_generation_agent.cc
diff --git a/components/autofill/content/renderer/password_generation_agent.cc b/components/autofill/content/renderer/password_generation_agent.cc
index 33c30aa55eda15f9cb792d15ced9e9837c4dfcab..90991a3c3ab0dc1bc16c04a61b139e9108bc0577 100644
--- a/components/autofill/content/renderer/password_generation_agent.cc
+++ b/components/autofill/content/renderer/password_generation_agent.cc
@@ -10,6 +10,7 @@
#include "base/logging.h"
#include "components/autofill/content/common/autofill_messages.h"
#include "components/autofill/content/renderer/form_autofill_util.h"
+#include "components/autofill/content/renderer/form_classifier.h"
#include "components/autofill/content/renderer/password_autofill_agent.h"
#include "components/autofill/content/renderer/password_form_conversion_utils.h"
#include "components/autofill/core/common/autofill_switches.h"
@@ -194,6 +195,15 @@ void PasswordGenerationAgent::OnDynamicFormsSeen() {
FindPossibleGenerationForm();
}
+void PasswordGenerationAgent::RunFormClassifierAndSaveVote(
+ blink::WebFormElement& web_form,
+ const PasswordForm& form) {
+ base::string16 generation_field;
+ ClassifyFormAndFindGenerationField(web_form, &generation_field);
+ Send(new AutofillHostMsg_SaveFormClassifierVote(routing_id(), form,
+ generation_field));
+}
+
void PasswordGenerationAgent::FindPossibleGenerationForm() {
if (!enabled_ || !render_frame())
return;
@@ -232,6 +242,7 @@ void PasswordGenerationAgent::FindPossibleGenerationForm() {
if (GetAccountCreationPasswordFields(
form_util::ExtractAutofillableElementsInForm(forms[i]),
&passwords)) {
+ RunFormClassifierAndSaveVote(forms[i], *password_form);
AccountCreationFormData ac_form_data(
make_linked_ptr(password_form.release()), passwords);
possible_account_creation_forms_.push_back(ac_form_data);

Powered by Google App Engine
This is Rietveld 408576698