Chromium Code Reviews| Index: components/password_manager/core/browser/password_form_manager.h |
| diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h |
| index 12e130cb42dd04fb00002f31ee18db5183cb5bd2..cb6006169d5ec1dc22e4f9977fc5edd2b5925103 100644 |
| --- a/components/password_manager/core/browser/password_form_manager.h |
| +++ b/components/password_manager/core/browser/password_form_manager.h |
| @@ -271,6 +271,9 @@ class PasswordFormManager : public PasswordStoreConsumer { |
| // Called after successful login on the form with a generated password. |
| void ReplacePresavedPasswordWithPendingCredentials(PasswordStore* store); |
| + // Saves the outcome of HTML parsing based form classifier to uploaded proto. |
|
dvadym
2016/06/16 10:04:38
uploaded -> upload
kolos1
2016/06/16 13:28:44
Done.
|
| + void SaveFormClassifierVote(const base::string16& generation_field); |
| + |
| private: |
| // ManagerAction - What does the manager do with this form? Either it |
| // fills it, or it doesn't. If it doesn't fill it, that's either |
| @@ -326,6 +329,13 @@ class PasswordFormManager : public PasswordStoreConsumer { |
| kFormTypeMax |
| }; |
| + // The outcome of the form classifier. |
| + enum FormClassifierOutcome { |
| + kNoOutcome, |
| + kNoGenerationElement, |
| + kFoundGenerationElement |
| + }; |
| + |
| // The maximum number of combinations of the three preceding enums. |
| // This is used when recording the actions taken by the form in UMA. |
| static const int kMaxNumActionsTaken = |
| @@ -432,6 +442,9 @@ class PasswordFormManager : public PasswordStoreConsumer { |
| // Adds a vote on password generation usage to |form_structure|. |
| void AddGeneratedVote(autofill::FormStructure* form_structure); |
| + // Adds a vote from HTML parsing based form classifier to |form_structure|. |
| + void AddFormClassifierVote(autofill::FormStructure* form_structure); |
| + |
| // Create pending credentials from provisionally saved form and forms received |
| // from password store. |
| void CreatePendingCredentials(); |
| @@ -527,6 +540,13 @@ class PasswordFormManager : public PasswordStoreConsumer { |
| // Whether generation popup was shown at least once. |
| bool generation_popup_was_shown_; |
| + // The outcome of HTML parsing based form classifier. |
| + FormClassifierOutcome form_classifier_outcome_; |
| + |
| + // If |form_classifier_outcome_| == kFoundGenerationElement, the field |
| + // contains the name of the detected generation element. |
| + base::string16 generation_element_detected_by_classifier_; |
| + |
| // Whether the saved password was overridden. |
| bool password_overridden_; |