lib/kernel_visitor.dart - Issue 2055213002: Fix crash on mandatory parameters with initializers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/kernel_visitor.dart

Issue 2055213002: Fix crash on mandatory parameters with initializers. (Closed) Base URL: git@github.com:dart-lang/rasta.git@for_in

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/kernel_visitor.dart

diff --git a/lib/kernel_visitor.dart b/lib/kernel_visitor.dart

index 82f9518d33db963a40b803f8d0e713f428637999..b2ca9b667531beeba9f98b0f5875701dfbc78ac6 100644

--- a/lib/kernel_visitor.dart

+++ b/lib/kernel_visitor.dart

@@ -2084,6 +2084,7 @@ class KernelVisitor extends Object

}

});

signature.forEachParameter((ParameterElement parameter) {

+ if (!parameter.isOptional) return;

ir.Expression initializer = parameter.initializer?.accept(this);

ir.VariableDeclaration variable = getLocal(parameter);

if (initializer != null) {

« no previous file with comments | « no previous file | test/kernel/regression/mandatory_parameter_initializer.dart » ('j') | no next file with comments »