cc: Apply occlusion before creating quads in RenderSurfaceImpl.

cc: Apply occlusion before creating quads in RenderSurfaceImpl.

This makes the AppendQuads method query occlusion directly and subtract
it from the quads it would create before they are created, skipping
quads that are completely occluded and avoiding a malloc/free for them.

Depends on: https://codereview.chromium.org/205443002/
Depends on: https://codereview.chromium.org/203463015/

R=enne
BUG=344962
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258633

[enne (OOO), 2014-03-19 23:05:32]

https://codereview.chromium.org/205503002/diff/1/cc/layers/render_surface_imp...
File cc/layers/render_surface_impl.cc (right):

https://codereview.chromium.org/205503002/diff/1/cc/layers/render_surface_imp...
cc/layers/render_surface_impl.cc:147:
quad_sink->UnoccludedContentRect(content_rect_, draw_transform);
Why does this not use UnoccludedContributingSurfaceContentRect? That's what
MaybeAppend would have done, I thought?

[danakj, 2014-03-19 23:12:32]

https://codereview.chromium.org/205503002/diff/1/cc/layers/render_surface_imp...
File cc/layers/render_surface_impl.cc (right):

https://codereview.chromium.org/205503002/diff/1/cc/layers/render_surface_imp...
cc/layers/render_surface_impl.cc:147:
quad_sink->UnoccludedContentRect(content_rect_, draw_transform);
On 2014/03/19 23:05:32, enne wrote:
> Why does this not use UnoccludedContributingSurfaceContentRect? That's what
> MaybeAppend would have done, I thought?

Cuz copy/paste, woops. Maybe I should add a separate occlusion rect in the
MockQuadCuller for this method?

[enne (OOO), 2014-03-19 23:18:36]

https://codereview.chromium.org/205503002/diff/1/cc/layers/render_surface_imp...
File cc/layers/render_surface_impl.cc (right):

https://codereview.chromium.org/205503002/diff/1/cc/layers/render_surface_imp...
cc/layers/render_surface_impl.cc:147:
quad_sink->UnoccludedContentRect(content_rect_, draw_transform);
On 2014/03/19 23:12:33, danakj wrote:
> On 2014/03/19 23:05:32, enne wrote:
> > Why does this not use UnoccludedContributingSurfaceContentRect? That's what
> > MaybeAppend would have done, I thought?
> 
> Cuz copy/paste, woops. Maybe I should add a separate occlusion rect in the
> MockQuadCuller for this method?

Yah.  Having a test that would have caught this sgtm.

[danakj, 2014-03-19 23:22:21]

https://codereview.chromium.org/205503002/diff/1/cc/layers/render_surface_imp...
File cc/layers/render_surface_impl.cc (right):

https://codereview.chromium.org/205503002/diff/1/cc/layers/render_surface_imp...
cc/layers/render_surface_impl.cc:147:
quad_sink->UnoccludedContentRect(content_rect_, draw_transform);
On 2014/03/19 23:18:36, enne wrote:
> On 2014/03/19 23:12:33, danakj wrote:
> > On 2014/03/19 23:05:32, enne wrote:
> > > Why does this not use UnoccludedContributingSurfaceContentRect? That's
what
> > > MaybeAppend would have done, I thought?
> > 
> > Cuz copy/paste, woops. Maybe I should add a separate occlusion rect in the
> > MockQuadCuller for this method?
> 
> Yah.  Having a test that would have caught this sgtm.

Done.

[enne (OOO), 2014-03-19 23:50:03]

lgtm

[danakj, 2014-03-20 21:46:04]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-03-20 21:48:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/205503002/80001

[commit-bot: I haz the power, 2014-03-20 21:55:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 21:55:36]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[danakj, 2014-03-20 22:01:56]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-03-20 22:06:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/205503002/80001

[commit-bot: I haz the power, 2014-03-20 22:12:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 22:12:41]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[danakj, 2014-03-20 22:14:25]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-03-20 22:16:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/205503002/80001

[commit-bot: I haz the power, 2014-03-20 22:26:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 22:26:23]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[danakj, 2014-03-20 22:27:30]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-03-20 22:30:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/205503002/80001

[commit-bot: I haz the power, 2014-03-20 22:38:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 22:38:59]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[danakj, 2014-03-20 22:39:41]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-03-20 22:40:38]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-03-20 22:41:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/205503002/100001

[commit-bot: I haz the power, 2014-03-20 22:41:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 22:41:47]

Failed to apply patch for cc/cc_tests.gyp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/cc_tests.gyp
  Hunk #1 FAILED at 41.
  1 out of 1 hunk FAILED -- saving rejects to file cc/cc_tests.gyp.rej

Patch:       cc/cc_tests.gyp
Index: cc/cc_tests.gyp
diff --git a/cc/cc_tests.gyp b/cc/cc_tests.gyp
index
afa8658d66545f1980eb0bfdb18b41149f40b922..c4e409b87b20004f029d63297fb955e5680d5796
100644
--- a/cc/cc_tests.gyp
+++ b/cc/cc_tests.gyp
@@ -41,9 +41,11 @@
       'layers/picture_layer_impl_unittest.cc',
       'layers/picture_layer_unittest.cc',
       'layers/render_surface_unittest.cc',
+      'layers/render_surface_impl_unittest.cc',
       'layers/scrollbar_layer_unittest.cc',
       'layers/solid_color_layer_impl_unittest.cc',
       'layers/texture_layer_unittest.cc',
+      'layers/texture_layer_impl_unittest.cc',
       'layers/tiled_layer_impl_unittest.cc',
       'layers/tiled_layer_unittest.cc',
       'layers/ui_resource_layer_impl_unittest.cc',

[danakj, 2014-03-20 23:34:01]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-03-20 23:34:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/205503002/120001

[danakj, 2014-03-20 23:35:04]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-03-20 23:42:57]

Failed to trigger a try job on win_x64_rel
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2014-03-20 23:43:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/205503002/140001

[commit-bot: I haz the power, 2014-03-21 00:38:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-21 00:38:47]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[danakj, 2014-03-21 16:34:37]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-03-21 16:35:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/205503002/140001

[commit-bot: I haz the power, 2014-03-21 18:41:13]

Change committed as 258633