Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1293)

Unified Diff: cc/layers/render_surface_impl_unittest.cc

Issue 205503002: cc: Apply occlusion before creating quads in RenderSurfaceImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: append-rendersurface: headers Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/render_surface_impl.cc ('k') | cc/test/layer_test_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/render_surface_impl_unittest.cc
diff --git a/cc/layers/io_surface_layer_impl_unittest.cc b/cc/layers/render_surface_impl_unittest.cc
similarity index 62%
copy from cc/layers/io_surface_layer_impl_unittest.cc
copy to cc/layers/render_surface_impl_unittest.cc
index 9a09bbd75fc4c3fbdb4cab5ae372b0e3de919108..20c2afbc84bc2e00b122ad142e365ade77602993 100644
--- a/cc/layers/io_surface_layer_impl_unittest.cc
+++ b/cc/layers/render_surface_impl_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "cc/layers/io_surface_layer_impl.h"
+#include "cc/layers/render_surface_impl.h"
#include "cc/test/layer_test_common.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -10,25 +10,28 @@
namespace cc {
namespace {
-TEST(IOSurfaceLayerImplTest, Occlusion) {
+TEST(RenderSurfaceLayerImplTest, Occlusion) {
gfx::Size layer_size(1000, 1000);
gfx::Size viewport_size(1000, 1000);
LayerTestCommon::LayerImplTest impl;
- IOSurfaceLayerImpl* io_surface_layer_impl =
- impl.AddChildToRoot<IOSurfaceLayerImpl>();
- io_surface_layer_impl->SetAnchorPoint(gfx::PointF());
- io_surface_layer_impl->SetBounds(layer_size);
- io_surface_layer_impl->SetContentBounds(layer_size);
- io_surface_layer_impl->SetDrawsContent(true);
+ LayerImpl* owning_layer_impl = impl.AddChildToRoot<LayerImpl>();
+ owning_layer_impl->SetAnchorPoint(gfx::PointF());
+ owning_layer_impl->SetBounds(layer_size);
+ owning_layer_impl->SetContentBounds(layer_size);
+ owning_layer_impl->SetDrawsContent(true);
+ owning_layer_impl->SetForceRenderSurface(true);
impl.CalcDrawProps(viewport_size);
+ RenderSurfaceImpl* render_surface_impl = owning_layer_impl->render_surface();
+ ASSERT_TRUE(render_surface_impl);
+
{
SCOPED_TRACE("No occlusion");
gfx::Rect occluded;
- impl.AppendQuadsWithOcclusion(io_surface_layer_impl, occluded);
+ impl.AppendSurfaceQuadsWithOcclusion(render_surface_impl, occluded);
LayerTestCommon::VerifyQuadsExactlyCoverRect(impl.quad_list(),
gfx::Rect(layer_size));
@@ -37,8 +40,8 @@ TEST(IOSurfaceLayerImplTest, Occlusion) {
{
SCOPED_TRACE("Full occlusion");
- gfx::Rect occluded(io_surface_layer_impl->visible_content_rect());
- impl.AppendQuadsWithOcclusion(io_surface_layer_impl, occluded);
+ gfx::Rect occluded(owning_layer_impl->visible_content_rect());
+ impl.AppendSurfaceQuadsWithOcclusion(render_surface_impl, occluded);
LayerTestCommon::VerifyQuadsExactlyCoverRect(impl.quad_list(), gfx::Rect());
EXPECT_EQ(impl.quad_list().size(), 0u);
@@ -47,7 +50,7 @@ TEST(IOSurfaceLayerImplTest, Occlusion) {
{
SCOPED_TRACE("Partial occlusion");
gfx::Rect occluded(200, 0, 800, 1000);
- impl.AppendQuadsWithOcclusion(io_surface_layer_impl, occluded);
+ impl.AppendSurfaceQuadsWithOcclusion(render_surface_impl, occluded);
size_t partially_occluded_count = 0;
LayerTestCommon::VerifyQuadsCoverRectWithOcclusion(
« no previous file with comments | « cc/layers/render_surface_impl.cc ('k') | cc/test/layer_test_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698