PaymentRequest: complete() method should take PaymentComplete enum value.

chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentResultUIManager.java

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentResultUIManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentResultUIManager.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentResultUIManager.java
index ebb171dbc3a5bad56937078755d84acf1325447c..7eb5965ae2a3d2aab44683d72a856a8b1f978eb5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentResultUIManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentResultUIManager.java
@@ -63,12 +63,13 @@ public class PaymentResultUIManager {
     /**
      * Updates the UI to display whether or not the payment request was successful.
      *
-     * @param paymentSuccess Whether or not the payment request was successful.
-     * @param callback       Callback to run upon dismissal.
+     * @param immediateClose Whether dismissing the dialog immediately without describing error.

[palmer, 2016/06/16 22:00:55]

Same issue here.

+     * @param callback Callback to run upon dismissal.
      */
-    public void update(boolean paymentSuccess, final Runnable callback) {
-        if (mResultLayout.getParent() == null || paymentSuccess) {
-            // Dismiss the dialog immediately.
+    public void update(boolean immediateClose, final Runnable callback) {
+        if (mResultLayout.getParent() == null || immediateClose) {
+            // if the complete() method takes success or empty string, immediateClose will be true.

[palmer, 2016/06/16 22:00:55]

I don't understand this comment.

[please use gerrit instead, 2016/06/16 22:06:11]

English is my second language as well, but perhaps this could be better:

// The immediateClose boolean is true when the merchant calls
// instrumentResponse.complete("success") or instrumentResponse.complete("")
// in JavaScript.

Thoughts?

+            // Then dismiss the dialog immediately.
             callback.run();
         } else {
             // Describe the error.