 Chromium Code Reviews
 Chromium Code Reviews Issue 2054823002:
  PaymentRequest: complete() method should take PaymentComplete enum value.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 2054823002:
  PaymentRequest: complete() method should take PaymentComplete enum value.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java | 
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java | 
| index ef8b5cbd5533c5c9d229e83967039fe32eed469f..fb71b06451b9b1a0b9be786dcdb037bdf1d4d031 100644 | 
| --- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java | 
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java | 
| @@ -398,12 +398,12 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View | 
| * | 
| * Should not be called multiple times. | 
| * | 
| - * @param paymentSuccess Whether the payment (if any) was successful. | 
| + * @param immediateClose Whether dismissing the dialog immediately without describing error. | 
| 
palmer
2016/06/16 22:00:55
This comment is not a complete English sentence. H
 | 
| * @param callback The callback to notify of finished animations. | 
| */ | 
| - public void close(boolean paymentSuccess, final Runnable callback) { | 
| + public void close(boolean immediateClose, final Runnable callback) { | 
| mIsClientClosing = true; | 
| - mResultView.update(paymentSuccess, new Runnable() { | 
| + mResultView.update(immediateClose, new Runnable() { | 
| @Override | 
| public void run() { | 
| dismissDialog(false); |