PaymentRequest: complete() method should take PaymentComplete enum value.

chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentResultUIManager.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.payments.ui;
 
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.view.LayoutInflater;
 import android.view.View;
@@ skipping 45 matching lines @@
                 (MarginLayoutParams) pageInfoGroup.getLayoutParams(), titleEndMargin);
 
         // Indicate that we're processing the data.
         TextView messageView = (TextView) mResultLayout.findViewById(R.id.message);
         messageView.setText(R.string.payments_processing_message);
     }
 
     /**
      * Updates the UI to display whether or not the payment request was successful.
      *
-     * @param paymentSuccess Whether or not the payment request was successful.
-     * @param callback       Callback to run upon dismissal.
+     * @param immediateClose Whether dismissing the dialog immediately without describing error.

[palmer, 2016/06/16 22:00:55]

Same issue here.

+     * @param callback Callback to run upon dismissal.
      */
-    public void update(boolean paymentSuccess, final Runnable callback) {
-        if (mResultLayout.getParent() == null || paymentSuccess) {
-            // Dismiss the dialog immediately.
+    public void update(boolean immediateClose, final Runnable callback) {
+        if (mResultLayout.getParent() == null || immediateClose) {
+            // if the complete() method takes success or empty string, immediateClose will be true.

[palmer, 2016/06/16 22:00:55]

I don't understand this comment.

[please use gerrit instead, 2016/06/16 22:06:11]

English is my second language as well, but perhaps this could be better:

// The immediateClose boolean is true when the merchant calls
// instrumentResponse.complete("success") or instrumentResponse.complete("")
// in JavaScript.

Thoughts?

+            // Then dismiss the dialog immediately.
             callback.run();
         } else {
             // Describe the error.
             Context context = mResultLayout.getContext();
             TextView resultMessage = (TextView) mResultLayout.findViewById(R.id.message);
             resultMessage.setText(context.getString(R.string.payments_error_message));
             resultMessage.setTextColor(ApiCompatibilityUtils.getColor(
                     context.getResources(), R.color.error_text_color));
             ApiCompatibilityUtils.setTextAlignment(resultMessage, View.TEXT_ALIGNMENT_VIEW_START);
 
@@ skipping 41 matching lines @@
      * TODO(dfalcantara): The dialog should listen for configuration changes and resize accordingly.
      */
     public static int computeMaxWidth(Context context, int availableWidth, int availableHeight) {
         int baseUnit = context.getResources().getDimensionPixelSize(R.dimen.dialog_width_unit);
         int maxSize = Math.min(availableWidth, availableHeight);
         int multiplier = maxSize / baseUnit;
         int floatingDialogWidth = multiplier * baseUnit;
         return floatingDialogWidth;
     }
 }