Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2053893003: [builtins] Introduce proper base::ieee754::log. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Mircea Trofin
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Introduce proper base::ieee754::log. This switches Math.log to use an fdlibm based version of log, imported as base::ieee754::log, and use that consistently everywhere, i.e. change the Float64Log TurboFan operators on Intel to use the C++ implementation as well (same for Crankshaft). R=yangguo@chromium.org BUG=v8:5065, v8:5086 Committed: https://crrev.com/d0c7775d7cfec5ae628ab9f3f00cff09b01930ac Cr-Commit-Position: refs/heads/master@{#36880}

Patch Set 1 #

Patch Set 2 : BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -177 lines) Patch
M BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/assembler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/assembler.cc View 3 chunks +5 lines, -8 lines 0 comments Download
A src/base/ieee754.h View 1 chunk +19 lines, -0 lines 0 comments Download
A src/base/ieee754.cc View 1 chunk +197 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/arm/instruction-scheduler-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/arm64/instruction-scheduler-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +13 lines, -10 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ia32/instruction-scheduler-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +9 lines, -10 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/x64/instruction-scheduler-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +11 lines, -24 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +4 lines, -26 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/external-reference-table.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/profiler/sampling-heap-profiler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 2 chunks +2 lines, -1 line 0 comments Download
M test/cctest/compiler/value-helper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-10 05:20:36 UTC) #1
Benedikt Meurer
Hey Yang, Here's the fdlibm unification for Math.log, as discussed offline. Please take a look. ...
4 years, 6 months ago (2016-06-10 05:22:26 UTC) #2
Yang
lgtm
4 years, 6 months ago (2016-06-10 05:32:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053893003/20001
4 years, 6 months ago (2016-06-10 05:33:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 05:52:05 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d0c7775d7cfec5ae628ab9f3f00cff09b01930ac Cr-Commit-Position: refs/heads/master@{#36880}
4 years, 6 months ago (2016-06-10 05:54:21 UTC) #8
Michael Achenbach
4 years, 6 months ago (2016-06-10 07:39:31 UTC) #9
Message was sent while issue was closed.
cc mtrofin

breaks greedy alloc

Powered by Google App Engine
This is Rietveld 408576698