src/compiler/x64/instruction-selector-x64.cc - Issue 2053893003: [builtins] Introduce proper base::ieee754::log.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/instruction-selector-x64.cc

Issue 2053893003: [builtins] Introduce proper base::ieee754::log. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: BUILD.gn Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/instruction-selector-x64.cc

diff --git a/src/compiler/x64/instruction-selector-x64.cc b/src/compiler/x64/instruction-selector-x64.cc

index fb4895157b5f8cbd1dd50c2fb5f237ab7ea295ed..5f7e5cf4813847bcdcb6e0d337027012ab28f270 100644

--- a/src/compiler/x64/instruction-selector-x64.cc

+++ b/src/compiler/x64/instruction-selector-x64.cc

@@ -1356,7 +1356,10 @@ void InstructionSelector::VisitFloat64Abs(Node* node) {

}

void InstructionSelector::VisitFloat64Log(Node* node) {

- VisitRR(this, node, kX87Float64Log);

+ X64OperandGenerator g(this);

+ Emit(kIeee754Float64Log, g.DefineAsFixed(node, xmm0),

+ g.UseFixed(node->InputAt(0), xmm0))

+ ->MarkAsCall();

}

void InstructionSelector::VisitFloat64Sqrt(Node* node) {