Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2060793002: Rewrite tests for slots (Closed)

Created:
4 years, 6 months ago by hayato
Modified:
4 years, 6 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@events-related
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite tests for slots Make the test more comprehensive, organized, and readable. BUG=531990 Committed: https://crrev.com/6502220de4e8cb4dbb28fe0ea21035453b02d3ac Cr-Commit-Position: refs/heads/master@{#400152}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+736 lines, -534 lines) Patch
M third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js View 1 chunk +11 lines, -11 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots.html View 1 1 chunk +506 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slots-api-1.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slots-api-2.html View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slots-api-dynamic.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slots-api-with-closed-shadow-tree.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slots-default-slot.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slots-dom-mutation.html View 1 chunk +0 lines, -53 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-fallback.html View 1 chunk +219 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-1.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-2.html View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-3.html View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-4.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slots-in-document-tree.html View 1 chunk +0 lines, -43 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060793002/1
4 years, 6 months ago (2016-06-13 09:18:03 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/20004) ios-device-gn on ...
4 years, 6 months ago (2016-06-13 09:19:56 UTC) #4
tkent
lgtm https://codereview.chromium.org/2060793002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/slots.html File third_party/WebKit/LayoutTests/shadow-dom/slots.html (right): https://codereview.chromium.org/2060793002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/slots.html#newcode173 third_party/WebKit/LayoutTests/shadow-dom/slots.html:173: <div id="c2" slot="slot1""></div> nit: Remove a redundant double-quote.
4 years, 6 months ago (2016-06-15 13:23:22 UTC) #7
hayato
fixed
4 years, 6 months ago (2016-06-16 07:49:00 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060793002/20001
4 years, 6 months ago (2016-06-16 07:49:09 UTC) #10
hayato
Thank you for the review. https://codereview.chromium.org/2060793002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/slots.html File third_party/WebKit/LayoutTests/shadow-dom/slots.html (right): https://codereview.chromium.org/2060793002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/slots.html#newcode173 third_party/WebKit/LayoutTests/shadow-dom/slots.html:173: <div id="c2" slot="slot1""></div> Done
4 years, 6 months ago (2016-06-16 07:49:24 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/82462) cast_shell_android on ...
4 years, 6 months ago (2016-06-16 07:52:29 UTC) #13
commit-bot: I haz the power
This CL has an open dependency (Issue 2053353002 Patch 40001). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-16 09:34:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060793002/20001
4 years, 6 months ago (2016-06-16 10:48:30 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 14:33:20 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 14:33:30 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 14:34:34 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6502220de4e8cb4dbb28fe0ea21035453b02d3ac
Cr-Commit-Position: refs/heads/master@{#400152}

Powered by Google App Engine
This is Rietveld 408576698