fxjse/DEPS - Issue 2053043002: Untangle bad depdenency from fxjse/ to fpdfsdk/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: fxjse/DEPS

Issue 2053043002: Untangle bad depdenency from fxjse/ to fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@move_fxjse

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 '+core/fxcrt/include',	2 '+core/fxcrt/include',

3 # TODO(dsinclair): Layering violation. FXJSE can't include FPDFSDK.

4 '+fpdfsdk/jsapi/include',

5 '+v8/include',	3 '+v8/include',

6 ]	4 ]

OLD	NEW

« no previous file with comments | « fpdfsdk/jsapi/include/fxjs_v8.h ('k') | fxjse/fxjs_perisolatedata.cpp » ('j') | no next file with comments »