Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issue 2052593005: Pass rangeOfInterest to metrics for the metrics side panel (Closed)

Created:
4 years, 6 months ago by benjhayden
Modified:
4 years, 6 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org, charliea (OOO until 10-5), rnephew (Reviews Here)
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Pass rangeOfInterest to metrics for the metrics side panel. Currently, metrics always act on the entire model. However, in trace-viewer, it is useful to be able to select a part of the model and ignore the rest. The metric side panel would be more useful if it allowed users to compute metrics for a selected time range. This CL updates responsivenessMetric and longTasksMetric as examples of this new capability, though any metric can optionally take a third "opt_options" parameter containing "rangeOfInterest". More options could be added to opt_options. Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a4f88ac68ed0607261df1d6a1f33d5239e97dfa7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M tracing/tracing/metrics/metric_registry.html View 1 chunk +4 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/system_health/long_tasks_metric.html View 1 chunk +7 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/system_health/responsiveness_metric.html View 2 chunks +11 lines, -1 line 0 comments Download
M tracing/tracing/ui/side_panel/metrics_side_panel.html View 3 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
benjhayden
PTAL
4 years, 6 months ago (2016-06-09 00:35:45 UTC) #3
eakuefner
lgtm
4 years, 6 months ago (2016-06-09 18:05:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052593005/1
4 years, 6 months ago (2016-06-09 18:22:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a4f88ac68ed0607261df1d6a1f33d5239e97dfa7
4 years, 6 months ago (2016-06-09 18:50:48 UTC) #8
nednguyen
4 years, 6 months ago (2016-06-09 20:49:27 UTC) #9
Message was sent while issue was closed.
+Charlie, Randy:

This can be used to replace the power graph brushing?

Powered by Google App Engine
This is Rietveld 408576698