Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1813)

Unified Diff: tracing/tracing/metrics/system_health/long_tasks_metric.html

Issue 2052593005: Pass rangeOfInterest to metrics for the metrics side panel (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/system_health/long_tasks_metric.html
diff --git a/tracing/tracing/metrics/system_health/long_tasks_metric.html b/tracing/tracing/metrics/system_health/long_tasks_metric.html
index c0270d8c8da4f9081c1aedfdc55847b6024d35bc..9ddd6a7dfb73b68e8a598c2920cd0027b475eda5 100644
--- a/tracing/tracing/metrics/system_health/long_tasks_metric.html
+++ b/tracing/tracing/metrics/system_health/long_tasks_metric.html
@@ -72,12 +72,17 @@ tr.exportTo('tr.metrics.sh', function() {
/**
* This metric directly measures long tasks on renderer main threads.
* This metric requires only the 'toplevel' tracing category.
+ *
+ * @param {!tr.metrics.ValueSet} values
+ * @param {!tr.model.Model} model
+ * @param {!Object=} opt_options
*/
- function longTasksMetric(values, model) {
+ function longTasksMetric(values, model, opt_options) {
+ var rangeOfInterest = opt_options ? opt_options.rangeOfInterest : undefined;
var longTaskNumeric = LONG_TASK_NUMERIC_BUILDER.build();
iterateRendererMainThreads(model, function(thread) {
iterateLongTopLevelTasksOnThreadInRange(
- thread, undefined, function(task) {
+ thread, rangeOfInterest, function(task) {
longTaskNumeric.add(task.duration, task.stableId);
});
});
« no previous file with comments | « tracing/tracing/metrics/metric_registry.html ('k') | tracing/tracing/metrics/system_health/responsiveness_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698