Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: tracing/tracing/metrics/system_health/responsiveness_metric.html

Issue 2052593005: Pass rangeOfInterest to metrics for the metrics side panel (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/system_health/responsiveness_metric.html
diff --git a/tracing/tracing/metrics/system_health/responsiveness_metric.html b/tracing/tracing/metrics/system_health/responsiveness_metric.html
index 62e13b521998ae6910391f0f138b5095d71567d3..01df0c6960d58126e7dc0b297d0ead74808396a6 100644
--- a/tracing/tracing/metrics/system_health/responsiveness_metric.html
+++ b/tracing/tracing/metrics/system_health/responsiveness_metric.html
@@ -69,7 +69,12 @@ tr.exportTo('tr.metrics.sh', function() {
tr.v.Unit.byName.timeDurationInMs_smallerIsBetter,
tr.b.Range.fromExplicitRange(0, 300), 60);
- function responsivenessMetric(values, model) {
+ /**
+ * @param {!tr.metrics.ValueSet} values
+ * @param {!tr.model.Model} model
+ * @param {!Object=} opt_options
+ */
+ function responsivenessMetric(values, model, opt_options) {
// TODO(benjhayden): Add categories to benchmark to support:
// tr.metrics.sh.firstPaintMetric(values, model);
@@ -79,6 +84,11 @@ tr.exportTo('tr.metrics.sh', function() {
var latencyNumeric = LATENCY_NUMERIC_BUILDER.build();
model.userModel.expectations.forEach(function(ue) {
+ if (opt_options && opt_options.rangeOfInterest &&
+ !opt_options.rangeOfInterest.intersectsExplicitRangeExclusive(
+ ue.start, ue.end))
+ return;
+
var sourceInfo = {userExpectationId: ue.stableId};
// Responsiveness is not defined for Idle.
« no previous file with comments | « tracing/tracing/metrics/system_health/long_tasks_metric.html ('k') | tracing/tracing/ui/side_panel/metrics_side_panel.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698