Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2047163003: Manual refactor to enum-based WaitableEvent for remaining _win files (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
danakj, fdoray
CC:
chromium-reviews, cbentzel+watch_chromium.org, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manual refactor to enum-based WaitableEvent for remaining _win files BUG=612843 R=fdoray@chromium.org TBR=danakj@chromium.org (Francois please fact check me, I'm TBRing dana for otherwise mechanical change) Committed: https://crrev.com/7c19b196f653ec0e2b3aab703611231efc04cb2a Cr-Commit-Position: refs/heads/master@{#398657}

Patch Set 1 #

Patch Set 2 : +sync_socket_win.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -17 lines) Patch
M base/sync_socket_win.cc View 1 1 chunk +9 lines, -5 lines 0 comments Download
M chrome/browser/chrome_select_file_dialog_factory_win.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M components/policy/core/common/policy_loader_win.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
gab
Francois please fact check me since this was done manually, otherwise TBR Dana for these ...
4 years, 6 months ago (2016-06-08 18:32:26 UTC) #1
gab
On 2016/06/08 18:32:26, gab wrote: > Francois please fact check me since this was done ...
4 years, 6 months ago (2016-06-08 19:06:31 UTC) #3
gab
On 2016/06/08 19:06:31, gab wrote: > On 2016/06/08 18:32:26, gab wrote: > > Francois please ...
4 years, 6 months ago (2016-06-08 19:43:34 UTC) #6
fdoray
lgtm
4 years, 6 months ago (2016-06-08 19:53:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047163003/20001
4 years, 6 months ago (2016-06-08 20:18:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-08 20:24:21 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7c19b196f653ec0e2b3aab703611231efc04cb2a Cr-Commit-Position: refs/heads/master@{#398657}
4 years, 6 months ago (2016-06-08 20:25:47 UTC) #13
danakj
4 years, 6 months ago (2016-06-09 20:38:30 UTC) #14
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698