chrome/test/chromedriver/commands.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/commands.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/log.cc ('k') | chrome/test/chromedriver/element_util.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/commands.cc

diff --git a/chrome/test/chromedriver/commands.cc b/chrome/test/chromedriver/commands.cc

index f5692f8d2a90e40d692fe632348287e4995ec808..85ecac8da6e3b729da5e44401913e26ae6f2808f 100644

--- a/chrome/test/chromedriver/commands.cc

+++ b/chrome/test/chromedriver/commands.cc

@@ -93,7 +93,7 @@ void OnGetSession(const base::WeakPtr<size_t>& session_remaining_count,

std::unique_ptr<base::DictionaryValue> session(new base::DictionaryValue());

session->Set("id", new base::StringValue(session_id));

session->Set("capabilities", value->DeepCopy());

- session_list->Append(session.release());

+ session_list->Append(std::move(session));

if (!*session_remaining_count) {

all_get_session_func.Run();

« no previous file with comments | « chrome/test/chromedriver/chrome/log.cc ('k') | chrome/test/chromedriver/element_util.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')