chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc ('k') | chrome/browser/extensions/api/tabs/tabs_event_router.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index c44a4af2e185ff27bbcabac631e1dc807d57c9bb..898a96e37b4e5de83005b3de094e70aff1a3b531 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -1025,8 +1025,7 @@ bool TabsQueryFunction::RunSync() {

result->Append(ExtensionTabUtil::CreateTabObject(web_contents, tab_strip,

i, extension())

- ->ToValue()

- .release());

+ ->ToValue());

}

@@ -1537,8 +1536,7 @@ bool TabsMoveFunction::MoveTab(int tab_id,

tab_values->Append(

ExtensionTabUtil::CreateTabObject(web_contents, target_tab_strip,

*new_index, extension())

- ->ToValue()

- .release());

+ ->ToValue());

}

return true;

@@ -1558,8 +1556,7 @@ bool TabsMoveFunction::MoveTab(int tab_id,

if (has_callback()) {

tab_values->Append(ExtensionTabUtil::CreateTabObject(

contents, source_tab_strip, *new_index, extension())

- ->ToValue()

- .release());

+ ->ToValue());

}

return true;