chrome/browser/extensions/api/settings_private/settings_private_delegate.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/settings_private/settings_private_delegate.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc ('k') | chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/settings_private/settings_private_delegate.cc

diff --git a/chrome/browser/extensions/api/settings_private/settings_private_delegate.cc b/chrome/browser/extensions/api/settings_private/settings_private_delegate.cc

index 8395e36b08fed1d267a119e0ebb8d12a6ca4c15a..1b5f72ea522978baa00ccf188be21ef4015ed9a8 100644

--- a/chrome/browser/extensions/api/settings_private/settings_private_delegate.cc

+++ b/chrome/browser/extensions/api/settings_private/settings_private_delegate.cc

@@ -47,7 +47,7 @@ std::unique_ptr<base::Value> SettingsPrivateDelegate::GetAllPrefs() {

for (const auto& it : keys) {

std::unique_ptr<base::Value> pref = GetPref(it.first);

if (!pref->IsType(base::Value::TYPE_NULL))

- prefs->Append(pref.release());

+ prefs->Append(std::move(pref));

}

return std::move(prefs);