chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/bookmarks/managed_bookmark_service_unittest.cc ('k') | chrome/browser/extensions/api/copresence/copresence_api_unittest.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

diff --git a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

index 3651cf5887392e9e7b4d7707963fdb5666ceda04..a3e5ae012246b2daf623fc3628f6eea8941a36f1 100644

--- a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

+++ b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

@@ -1064,7 +1064,7 @@ void BluetoothLowEnergyEventRouter::GattCharacteristicValueChanged(

apibtle::Characteristic api_characteristic;

PopulateCharacteristic(characteristic, &api_characteristic);

std::unique_ptr<base::ListValue> args(new base::ListValue());

- args->Append(apibtle::CharacteristicToValue(&api_characteristic).release());

+ args->Append(apibtle::CharacteristicToValue(&api_characteristic));

DispatchEventToExtensionsWithPermission(

events::BLUETOOTH_LOW_ENERGY_ON_CHARACTERISTIC_VALUE_CHANGED,

@@ -1095,7 +1095,7 @@ void BluetoothLowEnergyEventRouter::GattDescriptorValueChanged(

apibtle::Descriptor api_descriptor;

PopulateDescriptor(descriptor, &api_descriptor);

std::unique_ptr<base::ListValue> args(new base::ListValue());

- args->Append(apibtle::DescriptorToValue(&api_descriptor).release());

+ args->Append(apibtle::DescriptorToValue(&api_descriptor));

DispatchEventToExtensionsWithPermission(

events::BLUETOOTH_LOW_ENERGY_ON_DESCRIPTOR_VALUE_CHANGED,