Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2051163002: Nuke NaCl SFI, part 1. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Nuke NaCl SFI, part 1. (Some other cleanup to do separately/later too -- e.g., removing the private "SystemImpl" APIs.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d2811953d617f6cc35482b2ae49786ff42197e7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3410 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/nacl/config.gni View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
D mojo/nacl/sfi/BUILD.gn View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/nacl/sfi/README.md View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/nacl/sfi/monacl_shell.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings/BUILD.gn View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings/irt_entry_mojo.c View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings/mojo_irt.c View 1 chunk +0 lines, -477 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings/mojo_syscall.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings/mojo_syscall.cc View 1 chunk +0 lines, -1018 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings/mojo_syscall_internal.h View 1 chunk +0 lines, -238 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings/monacl_sel_main.h View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings/monacl_sel_main.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings_generator/generate_nacl_bindings.py View 1 chunk +0 lines, -586 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings_generator/interface.py View 1 chunk +0 lines, -175 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings_generator/interface_dsl.py View 1 chunk +0 lines, -166 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings_generator/libmojo.cc.tmpl View 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings_generator/mojo_irt.c.tmpl View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings_generator/mojo_irt.h.tmpl View 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/nacl/sfi/nacl_bindings_generator/mojo_syscall.cc.tmpl View 1 chunk +0 lines, -115 lines 0 comments Download
D mojo/tools/data/nacl_apptests View 1 chunk +0 lines, -21 lines 0 comments Download
M mojo/tools/get_test_list.py View 2 chunks +0 lines, -17 lines 0 comments Download
D services/nacl/sfi/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
D services/nacl/sfi/README.md View 1 chunk +0 lines, -8 lines 0 comments Download
D services/nacl/sfi/content_handler_main.cc View 1 chunk +0 lines, -157 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 6 months ago (2016-06-09 17:20:52 UTC) #1
viettrungluu
ping
4 years, 6 months ago (2016-06-14 17:22:48 UTC) #2
jamesr
lgtm
4 years, 6 months ago (2016-06-14 18:04:35 UTC) #3
viettrungluu
4 years, 6 months ago (2016-06-14 18:16:15 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d2811953d617f6cc35482b2ae49786ff42197e7a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698