Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: PRESUBMIT.py

Issue 2051163002: Nuke NaCl SFI, part 1. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/nacl/config.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 627 matching lines...) Expand 10 before | Expand all | Expand 10 after
638 638
639 def _CheckSpamLogging(input_api, output_api): 639 def _CheckSpamLogging(input_api, output_api):
640 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS 640 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS
641 black_list = (_EXCLUDED_PATHS + 641 black_list = (_EXCLUDED_PATHS +
642 _TEST_CODE_EXCLUDED_PATHS + 642 _TEST_CODE_EXCLUDED_PATHS +
643 input_api.DEFAULT_BLACK_LIST + 643 input_api.DEFAULT_BLACK_LIST +
644 (r"^base/logging\.h$", 644 (r"^base/logging\.h$",
645 r"^base/logging\.cc$", 645 r"^base/logging\.cc$",
646 r"^examples/.*$", 646 r"^examples/.*$",
647 r"^mojo/edk/util/logging_internal\.cc$", 647 r"^mojo/edk/util/logging_internal\.cc$",
648 r"^mojo/nacl/sfi/nacl_bindings/mojo_syscall\.cc$",
649 r"^services/log/main\.cc$", 648 r"^services/log/main\.cc$",
650 r"^shell/application_manager/network_fetcher\.cc$", 649 r"^shell/application_manager/network_fetcher\.cc$",
651 r"^shell/tracer\.cc$", 650 r"^shell/tracer\.cc$",
652 r"^sandbox/linux/.*", 651 r"^sandbox/linux/.*",
653 r"^tools/.*")) 652 r"^tools/.*"))
654 source_file_filter = lambda x: input_api.FilterSourceFile( 653 source_file_filter = lambda x: input_api.FilterSourceFile(
655 x, white_list=(file_inclusion_pattern,), black_list=black_list) 654 x, white_list=(file_inclusion_pattern,), black_list=black_list)
656 655
657 log_macro = input_api.re.compile(r"\bD?LOG\s*\(\s*INFO\s*\)") 656 log_macro = input_api.re.compile(r"\bD?LOG\s*\(\s*INFO\s*\)")
658 log_if_macro = input_api.re.compile(r"\bD?LOG_IF\s*\(\s*INFO\s*,") 657 log_if_macro = input_api.re.compile(r"\bD?LOG_IF\s*\(\s*INFO\s*,")
(...skipping 491 matching lines...) Expand 10 before | Expand all | Expand 10 after
1150 'Mojo Linux ASan Try', 1149 'Mojo Linux ASan Try',
1151 'Mojo Linux Try', 1150 'Mojo Linux Try',
1152 ] 1151 ]
1153 1152
1154 return GetDefaultTryConfigs(builders) 1153 return GetDefaultTryConfigs(builders)
1155 1154
1156 def PostUploadHook(cl, change, output_api): 1155 def PostUploadHook(cl, change, output_api):
1157 import subprocess 1156 import subprocess
1158 subprocess.check_call(["git", "cl", "try"]) 1157 subprocess.check_call(["git", "cl", "try"])
1159 return [] 1158 return []
OLDNEW
« no previous file with comments | « no previous file | build/config/nacl/config.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698