build/config/nacl/config.gni - Issue 2051163002: Nuke NaCl SFI, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/nacl/config.gni

Issue 2051163002: Nuke NaCl SFI, part 1. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/nacl/config.gni

diff --git a/build/config/nacl/config.gni b/build/config/nacl/config.gni

index 652c37a7e1e8365aae1ddf8dca4bef634b9ffdc9..24529c3ff7bbb1f1ee6f2183000f74ece3699074 100644

--- a/build/config/nacl/config.gni

+++ b/build/config/nacl/config.gni

@@ -10,9 +10,10 @@ declare_args() {

# TODO(ncbray): support ASAN once NaCl's GN build is unforked.

# TODO(cstout): support fnl/musl build in nacl

- mojo_use_nacl_sfi = is_linux && !is_asan && !is_fnl

mojo_use_nacl_nonsfi = (is_linux || is_android) && !is_asan && !is_fnl

- mojo_use_nacl = mojo_use_nacl_sfi || mojo_use_nacl_nonsfi

+ # TODO(vtl): This now seems totally redundant.

+ mojo_use_nacl = mojo_use_nacl_nonsfi

}

nacl_toolchain_dir = "//native_client/toolchain/${host_os}_x86"

« no previous file with comments | « PRESUBMIT.py ('k') | mojo/BUILD.gn » ('j') | no next file with comments »