cc : Push layer lists instead of layer tree at commit and activation

cc : Push layer lists instead of layer tree at commit and activation

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c
Cr-Commit-Position: refs/heads/master@{#398948}

[jaydasika, 2016-06-09 04:56:32]

Description was changed from

==========
cc : Push layer lists instead of layer tree at commit and activation

BUG=
==========

to

==========
cc : Push layer lists instead of layer tree at commit and activation

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-06-09 05:06:34]

Description was changed from

==========
cc : Push layer lists instead of layer tree at commit and activation

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Push layer lists instead of layer tree at commit and activation

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-06-09 05:07:53]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-06-09 05:07:54]

https://codereview.chromium.org/2051013002/diff/1/cc/layers/layer_position_co...
File cc/layers/layer_position_constraint_unittest.cc (right):

https://codereview.chromium.org/2051013002/diff/1/cc/layers/layer_position_co...
cc/layers/layer_position_constraint_unittest.cc:58:
LayerTreeHostCommon::CalculateDrawProperties(&inputs);
These tests construct layer tree on main thread and push it at commit to
compositor. So, we can't build property trees on compositor in these tests as
property tree building expects a layer tree.

https://codereview.chromium.org/2051013002/diff/1/cc/layers/scrollbar_layer_u...
File cc/layers/scrollbar_layer_unittest.cc (left):

https://codereview.chromium.org/2051013002/diff/1/cc/layers/scrollbar_layer_u...
cc/layers/scrollbar_layer_unittest.cc:169:
->BuildLayerListAndPropertyTreesForTesting();
Can't build property trees on compositor, they should be build on main thread
and send to it.

https://codereview.chromium.org/2051013002/diff/1/cc/trees/layer_tree_impl.cc
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/2051013002/diff/1/cc/trees/layer_tree_impl.cc...
cc/trees/layer_tree_impl.cc:264: void LayerTreeImpl::SetRootLayerFromLayerList()
{
This needs better name! root_layer_ should ultimately be removed, but that
should be a different CL.

[ajuma, 2016-06-09 15:15:20]

Nice work! Just a few small nits:

https://codereview.chromium.org/2051013002/diff/1/cc/trees/layer_tree_host_un...
File cc/trees/layer_tree_host_unittest_scroll.cc (right):

https://codereview.chromium.org/2051013002/diff/1/cc/trees/layer_tree_host_un...
cc/trees/layer_tree_host_unittest_scroll.cc:1150: void WillCommit() override {
If this is changed to UpdateLayerTreeHost, it will get called before the usual
call to building property trees, and then you won't need the
BuildPropertyTreesForTesting calls below.

https://codereview.chromium.org/2051013002/diff/1/cc/trees/layer_tree_impl.h
File cc/trees/layer_tree_impl.h (right):

https://codereview.chromium.org/2051013002/diff/1/cc/trees/layer_tree_impl.h#...
cc/trees/layer_tree_impl.h:154: std::vector<LayerImpl*>::reverse_iterator
rend();
There's a LayerImplList type defined (as vector<LayerImpl*>) in
layer_collections.h. Should we use that here? (Also as the type of layer_list_.)

https://codereview.chromium.org/2051013002/diff/1/cc/trees/tree_synchronizer.cc
File cc/trees/tree_synchronizer.cc (right):

https://codereview.chromium.org/2051013002/diff/1/cc/trees/tree_synchronizer....
cc/trees/tree_synchronizer.cc:118: void
SynchronizeTreesRecursive(OwnedLayerImplMap* old_layers,
Nit: this isn't recursive anymore. Would PushLayerList be a better name for it?

[jaydasika, 2016-06-09 16:56:26]

https://codereview.chromium.org/2051013002/diff/1/cc/trees/layer_tree_host_un...
File cc/trees/layer_tree_host_unittest_scroll.cc (right):

https://codereview.chromium.org/2051013002/diff/1/cc/trees/layer_tree_host_un...
cc/trees/layer_tree_host_unittest_scroll.cc:1150: void WillCommit() override {
On 2016/06/09 15:15:19, ajuma wrote:
> If this is changed to UpdateLayerTreeHost, it will get called before the usual
> call to building property trees, and then you won't need the
> BuildPropertyTreesForTesting calls below.

Done.

https://codereview.chromium.org/2051013002/diff/1/cc/trees/layer_tree_impl.h
File cc/trees/layer_tree_impl.h (right):

https://codereview.chromium.org/2051013002/diff/1/cc/trees/layer_tree_impl.h#...
cc/trees/layer_tree_impl.h:154: std::vector<LayerImpl*>::reverse_iterator
rend();
On 2016/06/09 15:15:19, ajuma wrote:
> There's a LayerImplList type defined (as vector<LayerImpl*>) in
> layer_collections.h. Should we use that here? (Also as the type of
layer_list_.)

Done.

https://codereview.chromium.org/2051013002/diff/1/cc/trees/tree_synchronizer.cc
File cc/trees/tree_synchronizer.cc (right):

https://codereview.chromium.org/2051013002/diff/1/cc/trees/tree_synchronizer....
cc/trees/tree_synchronizer.cc:118: void
SynchronizeTreesRecursive(OwnedLayerImplMap* old_layers,
On 2016/06/09 15:15:19, ajuma wrote:
> Nit: this isn't recursive anymore. Would PushLayerList be a better name for
it?

Done.

[ajuma, 2016-06-09 17:14:35]

Thanks, lgtm

[jaydasika, 2016-06-09 17:21:26]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-06-09 17:22:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2051013002/20001

[commit-bot: I haz the power, 2016-06-09 18:13:10]

Description was changed from

==========
cc : Push layer lists instead of layer tree at commit and activation

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Push layer lists instead of layer tree at commit and activation

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-06-09 18:13:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-09 18:17:30]

Description was changed from

==========
cc : Push layer lists instead of layer tree at commit and activation

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Push layer lists instead of layer tree at commit and activation

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c
Cr-Commit-Position: refs/heads/master@{#398948}
==========

[commit-bot: I haz the power, 2016-06-09 18:17:31]

Patchset 2 (id:??) landed as
https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c
Cr-Commit-Position: refs/heads/master@{#398948}