cc : Push layer lists instead of layer tree at commit and activation

cc/trees/tree_synchronizer_unittest.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/tree_synchronizer.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <set>
@@ skipping 60 matching lines @@
   }
 
  private:
   explicit MockLayer(std::vector<int>* layer_impl_destruction_list)
       : layer_impl_destruction_list_(layer_impl_destruction_list) {}
   ~MockLayer() override {}
 
   std::vector<int>* layer_impl_destruction_list_;
 };
 
-void ExpectTreesAreIdentical(Layer* layer,
-                             LayerImpl* layer_impl,
+void ExpectTreesAreIdentical(Layer* root_layer,
+                             LayerImpl* root_layer_impl,
                              LayerTreeImpl* tree_impl) {
-  ASSERT_TRUE(layer);
-  ASSERT_TRUE(layer_impl);
+  auto layer_iter = root_layer->layer_tree_host()->begin();
+  auto layer_impl_iter = tree_impl->begin();
+  for (; layer_iter != root_layer->layer_tree_host()->end();
+       ++layer_iter, ++layer_impl_iter) {
+    Layer* layer = *layer_iter;
+    LayerImpl* layer_impl = *layer_impl_iter;
+    ASSERT_TRUE(layer);
+    ASSERT_TRUE(layer_impl);
 
-  EXPECT_EQ(layer->id(), layer_impl->id());
-  EXPECT_EQ(layer_impl->layer_tree_impl(), tree_impl);
+    EXPECT_EQ(layer->id(), layer_impl->id());
+    EXPECT_EQ(layer_impl->layer_tree_impl(), tree_impl);
 
-  EXPECT_EQ(layer->non_fast_scrollable_region(),
-            layer_impl->non_fast_scrollable_region());
+    EXPECT_EQ(layer->non_fast_scrollable_region(),
+              layer_impl->non_fast_scrollable_region());
 
-  ASSERT_EQ(!!layer->mask_layer(), !!layer_impl->mask_layer());
-  if (layer->mask_layer()) {
-    SCOPED_TRACE("mask_layer");
-    ExpectTreesAreIdentical(layer->mask_layer(), layer_impl->mask_layer(),
-                            tree_impl);
-  }
+    ASSERT_EQ(!!layer->mask_layer(), !!layer_impl->mask_layer());
+    if (layer->mask_layer()) {
+      SCOPED_TRACE("mask_layer");
+      EXPECT_EQ(layer->mask_layer()->id(), layer_impl->mask_layer()->id());
+    }
 
-  ASSERT_EQ(!!layer->replica_layer(), !!layer_impl->replica_layer());
-  if (layer->replica_layer()) {
-    SCOPED_TRACE("replica_layer");
-    ExpectTreesAreIdentical(layer->replica_layer(), layer_impl->replica_layer(),
-                            tree_impl);
-  }
+    ASSERT_EQ(!!layer->replica_layer(), !!layer_impl->replica_layer());
+    if (layer->replica_layer()) {
+      SCOPED_TRACE("replica_layer");
+      EXPECT_EQ(layer->replica_layer()->id(),
+                layer_impl->replica_layer()->id());
+      ASSERT_EQ(!!layer->replica_layer()->mask_layer(),
+                !!layer_impl->replica_layer()->mask_layer());
+      if (layer->replica_layer()->mask_layer()) {
+        SCOPED_TRACE("mask_layer");
+        EXPECT_EQ(layer->replica_layer()->mask_layer()->id(),
+                  layer_impl->replica_layer()->mask_layer()->id());
+      }
+    }
 
-  const LayerList& layer_children = layer->children();
-  const LayerImplList& layer_impl_children = layer_impl->children();
+    const Layer* layer_scroll_parent = layer->scroll_parent();
 
-  ASSERT_EQ(layer_children.size(), layer_impl_children.size());
+    if (layer_scroll_parent) {
+      ASSERT_TRUE(layer_scroll_parent->scroll_children()->find(layer) !=
+                  layer_scroll_parent->scroll_children()->end());
+    }
 
-  const Layer* layer_scroll_parent = layer->scroll_parent();
+    const Layer* layer_clip_parent = layer->clip_parent();
 
-  if (layer_scroll_parent) {
-    ASSERT_TRUE(layer_scroll_parent->scroll_children()->find(layer) !=
-                layer_scroll_parent->scroll_children()->end());
-  }
-
-  const Layer* layer_clip_parent = layer->clip_parent();
-
-  if (layer_clip_parent) {
-    const std::set<Layer*>* clip_children = layer_clip_parent->clip_children();
-    ASSERT_TRUE(clip_children->find(layer) != clip_children->end());
-  }
-
-  for (size_t i = 0; i < layer_children.size(); ++i) {
-    SCOPED_TRACE(base::StringPrintf("child layer %" PRIuS, i).c_str());
-    ExpectTreesAreIdentical(layer_children[i].get(), layer_impl_children[i],
-                            tree_impl);
+    if (layer_clip_parent) {
+      const std::set<Layer*>* clip_children =
+          layer_clip_parent->clip_children();
+      ASSERT_TRUE(clip_children->find(layer) != clip_children->end());
+    }
   }
 }
 
 class TreeSynchronizerTest : public testing::Test {
  public:
   TreeSynchronizerTest()
       : client_(FakeLayerTreeHostClient::DIRECT_3D),
         host_(FakeLayerTreeHost::Create(&client_, &task_graph_runner_)) {}
 
  protected:
@@ skipping 47 matching lines @@
 
 // Constructs a very simple tree and synchronizes it attempting to reuse some
 // layers
 TEST_F(TreeSynchronizerTest, SyncSimpleTreeReusingLayers) {
   std::vector<int> layer_impl_destruction_list;
 
   scoped_refptr<Layer> layer_tree_root =
       MockLayer::Create(&layer_impl_destruction_list);
   layer_tree_root->AddChild(MockLayer::Create(&layer_impl_destruction_list));
   layer_tree_root->AddChild(MockLayer::Create(&layer_impl_destruction_list));
+  int second_layer_impl_id = layer_tree_root->children()[1]->id();
 
   host_->SetRootLayer(layer_tree_root);
 
   TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(),
                                      host_->active_tree());
   LayerImpl* layer_impl_tree_root = host_->active_tree()->root_layer();
   ExpectTreesAreIdentical(layer_tree_root.get(), layer_impl_tree_root,
                           host_->active_tree());
 
   // We have to push properties to pick up the destruction list pointer.
   TreeSynchronizer::PushLayerProperties(layer_tree_root->layer_tree_host(),
                                         host_->active_tree());
 
   // Add a new layer to the Layer side
   layer_tree_root->children()[0]->AddChild(
       MockLayer::Create(&layer_impl_destruction_list));
   // Remove one.
   layer_tree_root->children()[1]->RemoveFromParent();
-  int second_layer_impl_id = layer_impl_tree_root->children()[1]->id();
 
   // Synchronize again. After the sync the trees should be equivalent and we
   // should have created and destroyed one LayerImpl.
   TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(),
                                      host_->active_tree());
   layer_impl_tree_root = host_->active_tree()->root_layer();
 
   ExpectTreesAreIdentical(layer_tree_root.get(), layer_impl_tree_root,
                           host_->active_tree());
 
   ASSERT_EQ(1u, layer_impl_destruction_list.size());
   EXPECT_EQ(second_layer_impl_id, layer_impl_destruction_list[0]);
 
   host_->active_tree()->DetachLayers();
 }
 
 // Constructs a very simple tree and checks that a stacking-order change is
 // tracked properly.
 TEST_F(TreeSynchronizerTest, SyncSimpleTreeAndTrackStackingOrderChange) {
   std::vector<int> layer_impl_destruction_list;
 
   // Set up the tree and sync once. child2 needs to be synced here, too, even
   // though we remove it to set up the intended scenario.
   scoped_refptr<Layer> layer_tree_root =
       MockLayer::Create(&layer_impl_destruction_list);
   scoped_refptr<Layer> child2 = MockLayer::Create(&layer_impl_destruction_list);
   layer_tree_root->AddChild(MockLayer::Create(&layer_impl_destruction_list));
   layer_tree_root->AddChild(child2);
+  int child1_id = layer_tree_root->children()[0]->id();
+  int child2_id = layer_tree_root->children()[1]->id();
 
   host_->SetRootLayer(layer_tree_root);
 
   TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(),
                                      host_->active_tree());
   LayerImpl* layer_impl_tree_root = host_->active_tree()->root_layer();
   ExpectTreesAreIdentical(layer_tree_root.get(), layer_impl_tree_root,
                           host_->active_tree());
 
   // We have to push properties to pick up the destruction list pointer.
   TreeSynchronizer::PushLayerProperties(layer_tree_root->layer_tree_host(),
                                         host_->active_tree());
 
   host_->active_tree()->ResetAllChangeTracking();
 
   // re-insert the layer and sync again.
   child2->RemoveFromParent();
   layer_tree_root->AddChild(child2);
   TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(),
                                      host_->active_tree());
   layer_impl_tree_root = host_->active_tree()->root_layer();
   ExpectTreesAreIdentical(layer_tree_root.get(), layer_impl_tree_root,
                           host_->active_tree());
 
   TreeSynchronizer::PushLayerProperties(layer_tree_root->layer_tree_host(),
                                         host_->active_tree());
 
   // Check that the impl thread properly tracked the change.
   EXPECT_FALSE(layer_impl_tree_root->LayerPropertyChanged());
-  EXPECT_FALSE(layer_impl_tree_root->children()[0]->LayerPropertyChanged());
-  EXPECT_TRUE(layer_impl_tree_root->children()[1]->LayerPropertyChanged());
+  EXPECT_FALSE(
+      host_->active_tree()->LayerById(child1_id)->LayerPropertyChanged());
+  EXPECT_TRUE(
+      host_->active_tree()->LayerById(child2_id)->LayerPropertyChanged());
   host_->active_tree()->DetachLayers();
 }
 
 TEST_F(TreeSynchronizerTest, SyncSimpleTreeAndProperties) {
   scoped_refptr<Layer> layer_tree_root = Layer::Create();
   layer_tree_root->AddChild(Layer::Create());
   layer_tree_root->AddChild(Layer::Create());
 
   host_->SetRootLayer(layer_tree_root);
 
   // Pick some random properties to set. The values are not important, we're
   // just testing that at least some properties are making it through.
   gfx::PointF root_position = gfx::PointF(2.3f, 7.4f);
   layer_tree_root->SetPosition(root_position);
 
   gfx::Size second_child_bounds = gfx::Size(25, 53);
   layer_tree_root->children()[1]->SetBounds(second_child_bounds);
   layer_tree_root->children()[1]->SavePaintProperties();
+  int second_child_id = layer_tree_root->children()[1]->id();
 
   TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(),
                                      host_->active_tree());
   LayerImpl* layer_impl_tree_root = host_->active_tree()->root_layer();
   ExpectTreesAreIdentical(layer_tree_root.get(), layer_impl_tree_root,
                           host_->active_tree());
 
   TreeSynchronizer::PushLayerProperties(layer_tree_root->layer_tree_host(),
                                         host_->active_tree());
 
   // Check that the property values we set on the Layer tree are reflected in
   // the LayerImpl tree.
   gfx::PointF root_layer_impl_position = layer_impl_tree_root->position();
   EXPECT_EQ(root_position.x(), root_layer_impl_position.x());
   EXPECT_EQ(root_position.y(), root_layer_impl_position.y());
 
   gfx::Size second_layer_impl_child_bounds =
-      layer_impl_tree_root->children()[1]->bounds();
+      layer_impl_tree_root->layer_tree_impl()
+          ->LayerById(second_child_id)
+          ->bounds();
   EXPECT_EQ(second_child_bounds.width(),
             second_layer_impl_child_bounds.width());
   EXPECT_EQ(second_child_bounds.height(),
             second_layer_impl_child_bounds.height());
 }
 
 TEST_F(TreeSynchronizerTest, ReuseLayerImplsAfterStructuralChange) {
   std::vector<int> layer_impl_destruction_list;
 
   // Set up a tree with this sort of structure:
@@ skipping 305 matching lines @@
   scroll_offset_map[scroll_layer->id()]->PullDeltaForMainThread();
   scroll_offset_map[scroll_layer->id()]->SetCurrent(gfx::ScrollOffset(40, 50));
   scroll_offset_map[scroll_layer->id()]->PushFromMainThread(
       gfx::ScrollOffset(100, 100));
   scroll_offset_map[scroll_layer->id()]->PushPendingToActive();
   EXPECT_TRUE(is_equal(scroll_offset_map, scroll_tree.scroll_offset_map()));
 }
 
 }  // namespace
 }  // namespace cc