cc : Push layer lists instead of layer tree at commit and activation

cc/trees/layer_tree_impl.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TREES_LAYER_TREE_IMPL_H_
 #define CC_TREES_LAYER_TREE_IMPL_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 117 matching lines @@
   // Tracing methods.
   // ---------------------------------------------------------------------------
   void GetAllPrioritizedTilesForTracing(
       std::vector<PrioritizedTile>* prioritized_tiles) const;
   void AsValueInto(base::trace_event::TracedValue* dict) const;
 
   // Other public methods
   // ---------------------------------------------------------------------------
   LayerImpl* root_layer() const { return root_layer_; }
   void SetRootLayer(std::unique_ptr<LayerImpl>);
+  void SetRootLayerFromLayerList();
   bool IsRootLayer(const LayerImpl* layer) const;
   std::unique_ptr<OwnedLayerImplList> DetachLayers();
 
   void SetPropertyTrees(PropertyTrees* property_trees);
   PropertyTrees* property_trees() { return &property_trees_; }
 
   void UpdatePropertyTreesForBoundsDelta();
 
   void PushPropertiesTo(LayerTreeImpl* tree_impl);
 
   void MoveChangeTrackingToLayers();
 
-  LayerListIterator<LayerImpl> begin() const;
-  LayerListIterator<LayerImpl> end() const;
-  LayerListReverseIterator<LayerImpl> rbegin();
-  LayerListReverseIterator<LayerImpl> rend();
+  std::vector<LayerImpl*>::const_iterator begin() const;
+  std::vector<LayerImpl*>::const_iterator end() const;
+  std::vector<LayerImpl*>::reverse_iterator rbegin();
+  std::vector<LayerImpl*>::reverse_iterator rend();

[ajuma, 2016/06/09 15:15:19]

There's a LayerImplList type defined (as vector<LayerImpl*>) in
layer_collections.h. Should we use that here? (Also as the type of layer_list_.)

[jaydasika, 2016/06/09 16:56:25]

Done.

 
   struct CC_EXPORT ElementLayers {
     // Transform and opacity mutations apply to this layer.
     LayerImpl* main = nullptr;
     // Scroll mutations apply to this layer.
     LayerImpl* scroll = nullptr;
   };
 
   void AddToElementMap(LayerImpl* layer);
   void RemoveFromElementMap(LayerImpl* layer);
@@ skipping 303 matching lines @@
     return event_listener_properties_[static_cast<size_t>(event_class)];
   }
   void set_event_listener_properties(EventListenerClass event_class,
                                      EventListenerProperties event_properties) {
     event_listener_properties_[static_cast<size_t>(event_class)] =
         event_properties;
   }
 
   void ResetAllChangeTracking();
 
+  void AddToLayerList(LayerImpl* layer);
+
+  void ClearLayerList();
+
+  void BuildLayerListForTesting();
+
  protected:
   explicit LayerTreeImpl(
       LayerTreeHostImpl* layer_tree_host_impl,
       scoped_refptr<SyncedProperty<ScaleGroup>> page_scale_factor,
       scoped_refptr<SyncedTopControls> top_controls_shown_ratio,
       scoped_refptr<SyncedElasticOverscroll> elastic_overscroll);
   float ClampPageScaleFactorToLimits(float page_scale_factor) const;
   void PushPageScaleFactorAndLimits(const float* page_scale_factor,
                                     float min_page_scale_factor,
                                     float max_page_scale_factor);
@@ skipping 85 matching lines @@
   bool top_controls_shrink_blink_size_;
   float top_controls_height_;
 
   // The amount that the top controls are shown from 0 (hidden) to 1 (fully
   // shown).
   scoped_refptr<SyncedTopControls> top_controls_shown_ratio_;
 
   std::unique_ptr<PendingPageScaleAnimation> pending_page_scale_animation_;
 
  private:
-  void BuildLayerListForTesting();
   DISALLOW_COPY_AND_ASSIGN(LayerTreeImpl);
 };
 
 }  // namespace cc
 
 #endif  // CC_TREES_LAYER_TREE_IMPL_H_