chrome/browser/banners/app_banner_debug_log.h - Issue 2050933002: Upstream: Add additional checks before creating a WebAPK after clicking "Add to Homescreen"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_debug_log.h

Issue 2050933002: Upstream: Add additional checks before creating a WebAPK after clicking "Add to Homescreen" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher_unittest.cc ('k') | chrome/browser/banners/app_banner_debug_log.cc » ('j') | chrome/browser/banners/webapp_manifest_validator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_debug_log.h

diff --git a/chrome/browser/banners/app_banner_debug_log.h b/chrome/browser/banners/app_banner_debug_log.h

index e5e468e8524061933409525caaad20f5efcab87e..f6325bcd3bc587fa805fe28e4c512ee042ccb3dd 100644

--- a/chrome/browser/banners/app_banner_debug_log.h

+++ b/chrome/browser/banners/app_banner_debug_log.h

@@ -16,6 +16,7 @@ namespace banners {

// Error message strings used to notify developers via the console.

enum class OutputDeveloperMessageCode {

+ kNone,

kRendererRequestCancel,

kManifestEmpty,

kNoManifest,