Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3180)

Unified Diff: chrome/browser/banners/webapp_manifest_validator.h

Issue 2050933002: Upstream: Add additional checks before creating a WebAPK after clicking "Add to Homescreen" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_debug_log.cc ('k') | chrome/browser/banners/webapp_manifest_validator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/webapp_manifest_validator.h
diff --git a/chrome/browser/banners/webapp_manifest_validator.h b/chrome/browser/banners/webapp_manifest_validator.h
new file mode 100644
index 0000000000000000000000000000000000000000..6d11f5f0f20de7841b0bb28f9aa2d680f4319e5e
--- /dev/null
+++ b/chrome/browser/banners/webapp_manifest_validator.h
@@ -0,0 +1,31 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_BANNERS_WEBAPP_MANIFEST_VALIDATOR_H_
+#define CHROME_BROWSER_BANNERS_WEBAPP_MANIFEST_VALIDATOR_H_
+
+#include "chrome/browser/banners/app_banner_debug_log.h"
+
+namespace content {
+struct Manifest;
+}
+
+namespace banners {
+namespace webapp_manifest_validator {
+
+// Returns whether a page with |manifest| can be launched as a fullscreen web
+// app. If |manifest| prevents the page from launching as a fullscreen web app,
+// sets |code| to the reason why.
+bool IsWebappCapable(const content::Manifest& manifest,
+ OutputDeveloperMessageCode* code);
+
+// Returns true if a page with |manifest| will make a good fullscreen web app.
+// If not, sets |code| as to why.
pkotwicz 2016/06/09 01:39:38 I am not sold on this function name. Do you have a
+bool IsManifestGoodForWebapp(const content::Manifest& manifest,
+ OutputDeveloperMessageCode* code);
+
+} // namespace webapp_manifest_validator
+} // namespace banners
+
+#endif // CHROME_BROWSER_BANNERS_WEBAPP_MANIFEST_VALIDATOR_H_
« no previous file with comments | « chrome/browser/banners/app_banner_debug_log.cc ('k') | chrome/browser/banners/webapp_manifest_validator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698