chrome/browser/banners/app_banner_debug_log.cc - Issue 2050933002: Upstream: Add additional checks before creating a WebAPK after clicking "Add to Homescreen"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_debug_log.cc

Issue 2050933002: Upstream: Add additional checks before creating a WebAPK after clicking "Add to Homescreen" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/banners/app_banner_debug_log.h ('k') | chrome/browser/banners/webapp_manifest_validator.h » ('j') | chrome/browser/banners/webapp_manifest_validator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_debug_log.cc

diff --git a/chrome/browser/banners/app_banner_debug_log.cc b/chrome/browser/banners/app_banner_debug_log.cc

index 997a5d992502f8003a4462f4eeb1fb641c3a1021..7393e7d7844f3edc15f4e96d14039874ad562bd3 100644

--- a/chrome/browser/banners/app_banner_debug_log.cc

+++ b/chrome/browser/banners/app_banner_debug_log.cc

@@ -67,6 +67,8 @@ void OutputDeveloperNotShownMessage(content::WebContents* web_contents,

const char* pattern;

content::ConsoleMessageLevel severity = content::CONSOLE_MESSAGE_LEVEL_ERROR;

switch (code) {

+ case OutputDeveloperMessageCode::kNone:

+ return;

case OutputDeveloperMessageCode::kRendererRequestCancel:

pattern = kRendererRequestCancelMessage;

severity = content::CONSOLE_MESSAGE_LEVEL_LOG;