Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2050613003: Support resize in Android Viewer App (Closed)

Created:
4 years, 6 months ago by liyuqian
Modified:
4 years, 6 months ago
Reviewers:
jvanverth1, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Support resize in Android Viewer App Previously, we took out resize because Vulkan didn't support it in Android. Now Android nyc-dev builds >= 2937079 and nyc-release builds >= NRD66 supports it so we add it back. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050613003 Committed: https://skia.googlesource.com/skia/+/71491dc14cff017e175ae5eb555490559de67914

Patch Set 1 #

Patch Set 2 : Gradle #

Patch Set 3 : Title #

Patch Set 4 : OpenGL #

Total comments: 3

Patch Set 5 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -12 lines) Patch
M platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerApplication.java View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tools/viewer/Viewer.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M tools/viewer/sk_app/android/GLWindowContext_android.h View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M tools/viewer/sk_app/android/GLWindowContext_android.cpp View 1 2 3 4 2 chunks +11 lines, -5 lines 0 comments Download
M tools/viewer/sk_app/android/RasterWindowContext_android.h View 1 chunk +3 lines, -6 lines 0 comments Download
M tools/viewer/sk_app/android/RasterWindowContext_android.cpp View 2 chunks +16 lines, -1 line 0 comments Download
M tools/viewer/sk_app/android/surface_glue_android.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
liyuqian
4 years, 6 months ago (2016-06-08 20:45:09 UTC) #4
liyuqian
The "Viewer: " is removed in the title by a quick hack.
4 years, 6 months ago (2016-06-09 18:01:56 UTC) #5
liyuqian
I also turned Vulakn off by default because Nexus 9 doesn't have Vulkan driver.
4 years, 6 months ago (2016-06-09 18:11:59 UTC) #6
djsollen
lgtm with nits https://codereview.chromium.org/2050613003/diff/60001/tools/viewer/Viewer.cpp File tools/viewer/Viewer.cpp (right): https://codereview.chromium.org/2050613003/diff/60001/tools/viewer/Viewer.cpp#newcode56 tools/viewer/Viewer.cpp:56: DEFINE_bool(vulkan, false, "Run with Vulkan."); was ...
4 years, 6 months ago (2016-06-09 18:34:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050613003/80001
4 years, 6 months ago (2016-06-09 18:47:25 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 19:02:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/71491dc14cff017e175ae5eb555490559de67914

Powered by Google App Engine
This is Rietveld 408576698