Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 204983002: Re-land of issue 200623006: Set geometry dirty bits on composited layer mappings w/squashing (Closed)

Created:
6 years, 9 months ago by chrishtr
Modified:
6 years, 9 months ago
Reviewers:
ojan
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Re-land of issue 200623006: Set geometry dirty bits on composited layer mappings w/squashing Adds test expectation fix. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169608

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed cras. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -2 lines) Patch
A LayoutTests/compositing/squashing/squashed-layer-color-update.html View 1 chunk +45 lines, -0 lines 0 comments Download
A LayoutTests/compositing/squashing/squashed-layer-color-update-expected.html View 1 chunk +29 lines, -0 lines 0 comments Download
A + LayoutTests/virtual/softwarecompositing/squashing/squashed-layer-loses-graphicslayer-expected.txt View 1 chunk +23 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
chrishtr
6 years, 9 months ago (2014-03-19 18:51:56 UTC) #1
ojan
lgtm https://codereview.chromium.org/204983002/diff/1/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/204983002/diff/1/Source/core/rendering/RenderLayer.cpp#newcode3561 Source/core/rendering/RenderLayer.cpp:3561: if (!layerBeingDestroyed && m_groupedMapping) Nit, can this be ...
6 years, 9 months ago (2014-03-19 18:54:00 UTC) #2
chrishtr
https://codereview.chromium.org/204983002/diff/1/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/204983002/diff/1/Source/core/rendering/RenderLayer.cpp#newcode3561 Source/core/rendering/RenderLayer.cpp:3561: if (!layerBeingDestroyed && m_groupedMapping) On 2014/03/19 18:54:00, ojan wrote: ...
6 years, 9 months ago (2014-03-19 19:27:41 UTC) #3
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 9 months ago (2014-03-19 19:27:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/204983002/1
6 years, 9 months ago (2014-03-19 19:27:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 19:29:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-19 19:29:19 UTC) #7
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 9 months ago (2014-03-19 21:29:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/204983002/1
6 years, 9 months ago (2014-03-19 21:29:33 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 21:46:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-19 21:46:39 UTC) #11
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 9 months ago (2014-03-20 03:56:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/204983002/20001
6 years, 9 months ago (2014-03-20 03:56:17 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 03:57:40 UTC) #14
Message was sent while issue was closed.
Change committed as 169608

Powered by Google App Engine
This is Rietveld 408576698