Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2049743002: [build] Use icu data file by default (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Use icu data file by default BUG=chromium:616033 LOG=y Committed: https://crrev.com/77af83ba18b44ae88d7faa2a3cb87d098f2735b9 Cr-Commit-Position: refs/heads/master@{#36862}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M gypfiles/isolate.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M gypfiles/standalone.gypi View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049743002/1
4 years, 6 months ago (2016-06-08 15:10:05 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/2852)
4 years, 6 months ago (2016-06-08 15:15:57 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049743002/20001
4 years, 6 months ago (2016-06-09 07:52:20 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/2889)
4 years, 6 months ago (2016-06-09 07:53:51 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049743002/40001
4 years, 6 months ago (2016-06-09 07:55:30 UTC) #10
Michael Achenbach
PTAL. Guess we should have done this way earlier. Just realizing how much space and ...
4 years, 6 months ago (2016-06-09 08:11:44 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-09 08:23:44 UTC) #15
vogelheim
lgtm
4 years, 6 months ago (2016-06-09 13:17:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049743002/40001
4 years, 6 months ago (2016-06-09 13:21:26 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 13:23:08 UTC) #20
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 13:25:03 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/77af83ba18b44ae88d7faa2a3cb87d098f2735b9
Cr-Commit-Position: refs/heads/master@{#36862}

Powered by Google App Engine
This is Rietveld 408576698