Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: gypfiles/standalone.gypi

Issue 2049743002: [build] Use icu data file by default (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gypfiles/isolate.gypi ('k') | src/v8.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gypfiles/standalone.gypi
diff --git a/gypfiles/standalone.gypi b/gypfiles/standalone.gypi
index ccb94182663b3d95246ccc2e134b1a3875fb201b..a2047f1c40cfdd4a1c0c44f1f1652314f1f42028 100644
--- a/gypfiles/standalone.gypi
+++ b/gypfiles/standalone.gypi
@@ -149,6 +149,9 @@
'test_isolation_mode%': 'noop',
+ # By default, use ICU data file (icudtl.dat).
+ 'icu_use_data_file_flag%': 1,
+
'conditions': [
# Set default gomadir.
['OS=="win"', {
@@ -197,6 +200,7 @@
'fastbuild%': '<(fastbuild)',
'coverage%': '<(coverage)',
'sysroot%': '<(sysroot)',
+ 'icu_use_data_file_flag%': '<(icu_use_data_file_flag)',
# Add a simple extras solely for the purpose of the cctests
'v8_extra_library_files': ['../test/cctest/test-extra.js'],
« no previous file with comments | « gypfiles/isolate.gypi ('k') | src/v8.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698