gypfiles/isolate.gypi - Issue 2049743002: [build] Use icu data file by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gypfiles/isolate.gypi

Issue 2049743002: [build] Use icu data file by default (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gypfiles/isolate.gypi

diff --git a/gypfiles/isolate.gypi b/gypfiles/isolate.gypi

index a9614b5d64525e0e9e8283d5cda4af290bbf8185..085ed5d31b25c62b3402d8a7b0b44b26f56417e8 100644

--- a/gypfiles/isolate.gypi

+++ b/gypfiles/isolate.gypi

@@ -73,7 +73,7 @@

'--config-variable', 'cfi_vptr=<(cfi_vptr)',

'--config-variable', 'gcmole=<(gcmole)',

'--config-variable', 'has_valgrind=<(has_valgrind)',

- '--config-variable', 'icu_use_data_file_flag=0',

+ '--config-variable', 'icu_use_data_file_flag=<(icu_use_data_file_flag)',

'--config-variable', 'msan=<(msan)',

'--config-variable', 'tsan=<(tsan)',

'--config-variable', 'coverage=<(coverage)',

« no previous file with comments | « no previous file | gypfiles/standalone.gypi » ('j') | no next file with comments »