chrome/browser/ui/passwords/manage_passwords_ui_controller.cc - Issue 2049683002: Wire up the Chrome Sign In modal dialog from the password bubble promo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 2049683002: Wire up the Chrome Sign In modal dialog from the password bubble promo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

index e1b9ea854d6f7adaa73ff3ac7367cda3b2c261e0..35e48bc4973a5c00d0ac0cd76ab2959a14e1ebf6 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

@@ -333,7 +333,10 @@ void ManagePasswordsUIController::NavigateToPasswordManagerSettingsPage() {

}

void ManagePasswordsUIController::NavigateToChromeSignIn() {

- // TODO(http://crbug.com/615825): do the job.

+ Browser* browser = chrome::FindBrowserWithWebContents(web_contents());

+ browser->ShowModalSigninWindow(

gogerald1 2016/06/08 14:57:19 May use 'void BrowserView::ShowAvatarBubbleFromAva

vasilii 2016/06/08 17:48:24 Done.

+ profiles::BUBBLE_VIEW_MODE_GAIA_SIGNIN,

+ signin_metrics::AccessPoint::ACCESS_POINT_PASSWORD_BUBBLE);

}

void ManagePasswordsUIController::OnDialogHidden() {

« no previous file with comments | « no previous file | chrome/browser/ui/webui/signin/inline_login_handler.cc » ('j') | components/signin/core/browser/signin_metrics.h » ('J')