Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 2049683002: Wire up the Chrome Sign In modal dialog from the password bubble promo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h" 5 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "chrome/app/chrome_command_ids.h" 10 #include "chrome/app/chrome_command_ids.h"
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 chrome::Navigate(&params); 326 chrome::Navigate(&params);
327 } 327 }
328 328
329 void ManagePasswordsUIController::NavigateToPasswordManagerSettingsPage() { 329 void ManagePasswordsUIController::NavigateToPasswordManagerSettingsPage() {
330 chrome::ShowSettingsSubPage( 330 chrome::ShowSettingsSubPage(
331 chrome::FindBrowserWithWebContents(web_contents()), 331 chrome::FindBrowserWithWebContents(web_contents()),
332 chrome::kPasswordManagerSubPage); 332 chrome::kPasswordManagerSubPage);
333 } 333 }
334 334
335 void ManagePasswordsUIController::NavigateToChromeSignIn() { 335 void ManagePasswordsUIController::NavigateToChromeSignIn() {
336 // TODO(http://crbug.com/615825): do the job. 336 Browser* browser = chrome::FindBrowserWithWebContents(web_contents());
337 browser->ShowModalSigninWindow(
gogerald1 2016/06/08 14:57:19 May use 'void BrowserView::ShowAvatarBubbleFromAva
vasilii 2016/06/08 17:48:24 Done.
338 profiles::BUBBLE_VIEW_MODE_GAIA_SIGNIN,
339 signin_metrics::AccessPoint::ACCESS_POINT_PASSWORD_BUBBLE);
337 } 340 }
338 341
339 void ManagePasswordsUIController::OnDialogHidden() { 342 void ManagePasswordsUIController::OnDialogHidden() {
340 dialog_controller_.reset(); 343 dialog_controller_.reset();
341 if (GetState() == password_manager::ui::CREDENTIAL_REQUEST_STATE) { 344 if (GetState() == password_manager::ui::CREDENTIAL_REQUEST_STATE) {
342 passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE); 345 passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE);
343 UpdateBubbleAndIconVisibility(); 346 UpdateBubbleAndIconVisibility();
344 } 347 }
345 } 348 }
346 349
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
435 passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE); 438 passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE);
436 } 439 }
437 } 440 }
438 441
439 void ManagePasswordsUIController::WebContentsDestroyed() { 442 void ManagePasswordsUIController::WebContentsDestroyed() {
440 password_manager::PasswordStore* password_store = 443 password_manager::PasswordStore* password_store =
441 GetPasswordStore(web_contents()); 444 GetPasswordStore(web_contents());
442 if (password_store) 445 if (password_store)
443 password_store->RemoveObserver(this); 446 password_store->RemoveObserver(this);
444 } 447 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/webui/signin/inline_login_handler.cc » ('j') | components/signin/core/browser/signin_metrics.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698