components/signin/core/browser/signin_metrics.h - Issue 2049683002: Wire up the Chrome Sign In modal dialog from the password bubble promo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/signin_metrics.h

Issue 2049683002: Wire up the Chrome Sign In modal dialog from the password bubble promo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_ui_controller.cc ('K') | « chrome/browser/ui/webui/signin/inline_login_handler.cc ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/signin_metrics.h

diff --git a/components/signin/core/browser/signin_metrics.h b/components/signin/core/browser/signin_metrics.h

index e825fb663c364b21cb01e47d69ae3de56aaa666c..ed373b8a9d3d1d1c2cbab4f112a0f79cc4132d8b 100644

--- a/components/signin/core/browser/signin_metrics.h

+++ b/components/signin/core/browser/signin_metrics.h

@@ -136,6 +136,7 @@ enum class AccessPoint : int {

ACCESS_POINT_CONTENT_AREA,

ACCESS_POINT_SIGNIN_PROMO,

ACCESS_POINT_RECENT_TABS,

+ ACCESS_POINT_PASSWORD_BUBBLE,

gogerald1 2016/06/08 14:57:19 move it after ACCESS_POINT_UNKNOWN, and update Sig

vasilii 2016/06/08 17:48:24 Done.

ACCESS_POINT_UNKNOWN, // This should never have been used to get signin URL.

ACCESS_POINT_MAX, // This must be last.

};