Issue 2049503004: Add a "not signed in" condition to the Sync promo in the password bubble.

Issue 2049503004: Add a "not signed in" condition to the Sync promo in the password bubble. (Closed)

Created:
4 years, 6 months ago by vasilii

Modified:
4 years, 6 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add a "not signed in" condition to the Sync promo in the password bubble. BUG=615825 Committed: https://crrev.com/4631f2a7588dd6690d61e60e594182b87e1e28ff Cr-Commit-Position: refs/heads/master@{#398522}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -22 lines)			Patch
M	chrome/browser/ui/passwords/manage_passwords_bubble_model.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	components/password_manager/core/browser/password_bubble_experiment.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	components/password_manager/core/browser/password_bubble_experiment.cc	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	components/password_manager/core/browser/password_bubble_experiment_unittest.cc	View	5 chunks	+31 lines, -19 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049503004/1

4 years, 6 months ago (2016-06-08 11:38:02 UTC) #5

commit-bot: I haz the power

4 years, 6 months ago (2016-06-08 11:57:14 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4631f2a7588dd6690d61e60e594182b87e1e28ff
Cr-Commit-Position: refs/heads/master@{#398522}